Lucas Bremgartner
Lucas Bremgartner
@earthboundkid I mentioned `return` in the description as a potential alternative already. But as described, this always adds additional conditions, which increases the number of possible code paths (cyclomatic complexity)...
@rsc thanks for your proposed `passnow` package. I will consider this idea. I guess it boils down to `unsafe` versus `panic`. I understand, that there is very little to no...
To add to this discussion, I just stumbled over this code in our tests: ```golang assert.NotEqual(t, ``, somevar) ``` and I think, the linter should suggest ```golang assert.NotEmpty(t, somevar) ```...
@stgraber since this is likely a bug in Incus we should create an issue in https://github.com/lxc/incus, what do you think?
Looks like I just hit this issue in one of the GH pipelines: https://github.com/lxc/terraform-provider-incus/actions/runs/18498594527/job/52709079559?pr=334#step:6:185
#49 is somewhat related to this issue.
Maybe the implementation for the equality check could be made configurable. `reflect.DeepEqual` would stay the default in this case and those it would not break anything for existing users of...
> One alternative to bumping the version and going all-in on `go-cmp` might be to see if there is a less painful way to detect just those edge cases which...
Hi @Integralist Thanks for using `errchkjson`. I tried to reproduce your issue, but I was not successful. I added your example as a test case (https://github.com/breml/errchkjson/commit/2ae7e79f9ed8e086ded81047b66d7a0b03a8b1fc), but the test does...
Sorry for letting you wait for so long, but real live sometimes takes crazy turns. The problem you are facing is, that `golangci-lint` does not have the same default values...