Lucas Bremgartner

Results 245 comments of Lucas Bremgartner
trafficstars

> > does not render the API documentation > > Interesting, I might reach out to the team to understand what's going on, the documentation for the root package seems...

@baywet I can confirm, that I observed the same as you are describing and this worries me as well. I had a small conversation on Gopher Slack about this issue...

@baywet Yes, I am pretty sure, that the Go team would like to understand why we see these kind of build times regardless of the fact, if the code uses...

@baywet I agree, it is very unfortunate, that there has not been any response so far on your issue. The only thing that happened, was the assignment of two labels....

Also `x/pkgsite` is affected, because https://pkg.go.dev refuses to render the API documentation.

@baywet Thank you for putting your self into the fire and I am sorry, for the negative feedback you received regarding mentioning people directly (especially, because I proposed it). That...

I am not sure, if this is really an issue with `moq` it self. If one executes `go generate ./...` it will traverse through all the packages in sequence and...

My assumption is, that loading the package information (https://github.com/matryer/moq/blob/13aa0482dc83d813df2ae11a107bf1f697298d09/internal/registry/registry.go#L130) is the most expensive part, especially if `moq` is used in a rather large module / repository or if there are...

For Approach 2 I think we would need to rethink the way `moq` is used. In that scenario I would expect to only have a small number of `go:generate` lines...

I looked into this in a more detail and it looks like the underlying `github.com/lfittl/pg_query_go` does not return the correct information. Given the following example: ```Go package main import (...