bref icon indicating copy to clipboard operation
bref copied to clipboard

Support secrets from AWS Secrets Manager

Open natepage opened this issue 1 year ago • 4 comments

Hi there!

Would like to know if the idea of extending bref/secrets-loader to support fetching secrets from AWS Secrets Manager would be welcome?

If yes, would be happy to work on a PR 😄

natepage avatar Apr 18 '23 10:04 natepage

We are currently printing env vars (fetching them from AWS Secrets Manager) in pipeline to file and including the env file in deployment. Not ideal, but works. Having direct support would be appreciated with possibility to change them without need for deployment, however, we faced an issue with SSH and OAuth keys being too big and exceeding Lambda's env var limit.

sladg avatar Jun 06 '23 17:06 sladg

Hi! Working on this feature is not at the top of my priorities at the moment (for lack of time), but I'm happy to talk about company sponsoring so that I can prioritize this development ❤️ Feel free to reach out at [email protected]

mnapoli avatar Jun 06 '23 21:06 mnapoli

Hi @mnapoli 👋 Thank you for taking the time to respond to me.

I can only imagine how time consuming it would be for you to look after Bref, as I said in my original message, if the idea of such feature was welcome I would be happy to work on a PR to avoid you having to do it, that's what open-source is for 😄

Based on the comment from @sladg here, and this issue on secrets-loader itself, it looks like I'm not the only one who would enjoy this feature.

So here is a PR I've put together: https://github.com/brefphp/secrets-loader/pull/4

Thanks again for responding, and looking forward to hearing from you 😉

natepage avatar Aug 08 '23 01:08 natepage

Hey @natepage that looks awesome, thanks for the PR!

I'll review that in more details ASAP

mnapoli avatar Aug 08 '23 10:08 mnapoli