breezmobile
breezmobile copied to clipboard
lnurlw not using http on .onion sites
as per https://github.com/fiatjaf/lnurl-rfc/blob/luds/17.md
I did a quick test using nfc and saw that it tried to use https on my onion url.
I was using orbot to make breez be able to make tor requests, so in retrospect, breez has no official support for tor, but it would be cool if it did at least this much.
Did you do this? https://t.me/lnurl/32585
Yes
To be clearer, lnurlw:// and other scheme's are converted to https
, but when .onion
is used, it should use http
Gotcha. We might need your help with a test site, could you please provide an email? @ademar111190 please follow up.
Is there a way to give an email privately? If you provide your email, I can email you... I don't want my email on this public forum.
Sure, please send a note to: [email protected]
I found the root of the problem, and the fix is here https://github.com/fiatjaf/go-lnurl/pull/13
once it is merged on the go-lnurl
library, we need to update it on breez lib to have the fix on our app.
Nice
Looks like it's merged 👀👀
Yeap 🥳
I'm waiting for a new release of the lib including the fix, 1.12.0
or 1.11.3
:) https://github.com/fiatjaf/go-lnurl/issues/14#issuecomment-1265355349
Excellent, I'll update it on our library asap, thank you @dipunm
Merged to mobile. Will be released in our next update.