breezmobile icon indicating copy to clipboard operation
breezmobile copied to clipboard

lnurlw not using http on .onion sites

Open dipunm opened this issue 1 year ago • 10 comments

as per https://github.com/fiatjaf/lnurl-rfc/blob/luds/17.md

I did a quick test using nfc and saw that it tried to use https on my onion url.

dipunm avatar Sep 04 '22 21:09 dipunm

I was using orbot to make breez be able to make tor requests, so in retrospect, breez has no official support for tor, but it would be cool if it did at least this much.

dipunm avatar Sep 04 '22 22:09 dipunm

Did you do this? https://t.me/lnurl/32585

kingonly avatar Sep 05 '22 02:09 kingonly

Yes

dipunm avatar Sep 05 '22 08:09 dipunm

To be clearer, lnurlw:// and other scheme's are converted to https, but when .onion is used, it should use http

dipunm avatar Sep 05 '22 08:09 dipunm

Gotcha. We might need your help with a test site, could you please provide an email? @ademar111190 please follow up.

kingonly avatar Sep 05 '22 09:09 kingonly

Is there a way to give an email privately? If you provide your email, I can email you... I don't want my email on this public forum.

dipunm avatar Sep 05 '22 11:09 dipunm

Sure, please send a note to: [email protected]

kingonly avatar Sep 05 '22 11:09 kingonly

I found the root of the problem, and the fix is here https://github.com/fiatjaf/go-lnurl/pull/13 once it is merged on the go-lnurl library, we need to update it on breez lib to have the fix on our app.

ademar111190 avatar Sep 16 '22 17:09 ademar111190

Nice

dipunm avatar Sep 16 '22 18:09 dipunm

Looks like it's merged 👀👀

dipunm avatar Sep 24 '22 20:09 dipunm

Yeap 🥳

I'm waiting for a new release of the lib including the fix, 1.12.0 or 1.11.3

ademar111190 avatar Sep 26 '22 13:09 ademar111190

:) https://github.com/fiatjaf/go-lnurl/issues/14#issuecomment-1265355349

dipunm avatar Oct 03 '22 15:10 dipunm

Excellent, I'll update it on our library asap, thank you @dipunm

ademar111190 avatar Oct 03 '22 18:10 ademar111190

Merged to mobile. Will be released in our next update.

kingonly avatar Oct 23 '22 19:10 kingonly