breezmobile icon indicating copy to clipboard operation
breezmobile copied to clipboard

Allow checking the checkbox by tapping on the corresponding label

Open bolatovumar opened this issue 4 years ago • 7 comments

When setting up the app I kept trying to tap on the label to check the checkbox as is often the convention. I took me a couple of taps to realize that I wasn't just mistapping but that I had to tap on the checkbox itself.

It would be nice if tapping the label also checked the checkbox. I can attempt to implement this if ACKed. I don't have much experience with Dart but could be fun to dive into.

Screenshot_20191222-100815 Screenshot_20191222-100711

bolatovumar avatar Dec 22 '19 18:12 bolatovumar

Thanks for your report.

I can attempt to implement this if ACKed. I don't have much experience with Dart but could be fun to dive into

Sounds good.

roeierez avatar Dec 23 '19 07:12 roeierez

@roeierez looks like the https://github.com/breez/breez repo could use additional documentation as I couldn't follow the steps to build it. It's probably an environment difference issue.

bolatovumar avatar Dec 25 '19 20:12 bolatovumar

@roeierez looks like the https://github.com/breez/breez repo could use additional documentation as I couldn't follow the steps to build it. It's probably an environment difference issue.

I will be happy to improve it. Can you elaborate more on which step has failed?

roeierez avatar Dec 25 '19 20:12 roeierez

@roeierez I opened an issue for it here: https://github.com/breez/breez/issues/104

bolatovumar avatar Dec 26 '19 00:12 bolatovumar

@bolatovumar thanks. As result of your feedback I revisited both projects build documentation. I hope now it is more clear and here for any additional feedback.

roeierez avatar Dec 26 '19 11:12 roeierez

@roeierez thanks, I can build now and will attempt the remaining steps to build the app.

bolatovumar avatar Dec 28 '19 04:12 bolatovumar

@roeierez on step 2 it says: Copy breez.aar to the android/app/libs/ directory

Where is the android/apps/libs directory meant be found on my system? I searched for android directory on my end and there are many and I'm not sure which one I'm supposed to copy the breez.aar file into.

bolatovumar avatar Dec 28 '19 04:12 bolatovumar