jason plumb

Results 324 comments of jason plumb

@evantorrie At first glance, this doesn't seem too bad. The `JaegerRemoteSamplerBuilder` has these methods: * `setSslContext` * `setClientTls` * `setTrustedCertificates` Do you think that those provide enough to get mTLS...

I think this is problematic for the reason @jkwatson described and for the precision problem that the submitter raised. Still might be possible. I wonder if it also raises a...

> > Do you have any known examples of this, or is it hypothetical? > > If exporting metrics to NewRelic via their metric API, the payload must be in...

s/contrast/context/ in the first sentence. Just had me a little confused. 🙃

@NickAnge I'm not aware of anything in the sdk or the agent that tracks the entirety of a trace lifecycle in the way you're describing. Traces are often spread across...

Recommend linking to that spec issue here, so that it can more easily be followed up on.

My $0.02 -- I could see at first glance why one might want this, but I've been frowning at `Optional` method arguments for so long it might require some additional...

> Thanks for the link to #4336. Changing the specification to ignore nulls, which matches the current behavior of the primary implementation, seems like a better option. Yeah, but keep...

@rapphil I agree with @jmacd and think that your suggestion is a good one. Would you be able to submit a PR with that change?

@open-telemetry/java-instrumentation-approvers did we auto-generate that list once upon a time? I'm guessing it wasn't hand edited.....was it?