pldb icon indicating copy to clipboard operation
pldb copied to clipboard

Question: anyone know if GitHub has a URL scheme where I can generate a GET URL with params to pre-populate a pull request?

Open breck7 opened this issue 3 years ago • 6 comments

Does that make sense? The idea is as you edit a file on build, you have the choice to save directly or go to GitHub and submit it as a PR.

Screen Shot 2022-09-10 at 1 55 30 AM

breck7 avatar Sep 10 '22 11:09 breck7

You were talking about parsers getting grammar validation, as a feature recently. Would you validate the files after each web edit and what if the data sources in production become divergent from one in git hub (sent via pull requests) ?

ghost avatar Sep 11 '22 03:09 ghost

You were talking about parsers getting grammar validation, as a feature recently.

Oh yeah maybe I should add that tonight.

what if the data sources in production become divergent from one in git

Good question. Let's cross that bridge when we come to it (enough times that it becomes a problem)

breck7 avatar Sep 11 '22 06:09 breck7

It should be possible to create diffs using git and sending them to someone using Email.

Creating pull requests from diffs created using email should be much easier, if GitHub does not provide this service.

ghost avatar Oct 07 '22 11:10 ghost

Oh @SRS-WRKS this is a great idea!

breck7 avatar Oct 07 '22 14:10 breck7

This is as far as i have gotten on this issue : https://github.com/breck7/pldb/compare/main%40%7B1day%7D...main

and

https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/proposing-changes-to-your-work-with-pull-requests/about-comparing-branches-in-pull-requests#three-dot-and-two-dot-git-diff-comparisons

ghost avatar Dec 01 '22 05:12 ghost

This could be an item in https://github.com/breck7/pldb/issues/53

breck7 avatar Jan 01 '23 16:01 breck7

Eventually we should add this

breck7 avatar May 19 '24 18:05 breck7