In CSV docs, computed columns should link to the function in the File.ts file that computes them

Open breck7 opened this issue 3 years ago • 4 comments

For example, the last column for exampleCount: Screen Shot 2022-09-30 at 12 58 13 PM

should say exampleCount() and link to the following:

https://github.com/breck7/pldb/blob/97ef6c487a87ede910ffd252e5e97036ef53a9a9/code/File.ts#L204

Sep 30 '22 22:09 breck7

Thanks to PV for bringing this up!

Sep 30 '22 23:09 breck7

Hi @breck7 , I will work on this.

Oct 03 '22 07:10 mahadwaseem123

Hi @breck7 , this is resolved in the above PR. Kindly have a look.

Oct 04 '22 11:10 mahadwaseem123

Hi @breck7 , this issue is fixed in #192 . Kindly check and let me know if you like it. As the changes were in csvImports.scroll file and it is in git ignore, I have to forcefully add the complete updated file. Let me know if we can use different approach here or if this is fine. Thank you.

Oct 05 '22 19:10 mahadwaseem123

Done

Jan 16 '23 11:01 breck7