pldb icon indicating copy to clipboard operation
pldb copied to clipboard

Add advanced search

Open breck7 opened this issue 3 years ago • 6 comments

https://github.com/breck7/pldb/discussions/120

breck7 avatar Sep 24 '22 14:09 breck7

Hi @breck7 , I want to try working on this issue but have some questions around it.

1-Can we use any external js library for advance search? 2-How much time may I spend on this feature?

Any suggestions will be really helpful for me.

mahadwaseem123 avatar Oct 08 '22 21:10 mahadwaseem123

Hi @mahadwaseem123 no I don't think we should use an external library.

I think we should study how VS Code and Sublime Text have advanced search, and just copy theirs. Basically probably just add Regex search and operators like OR/AND/ et cetera.

Spend as much time as you want. It's an interesting problem

breck7 avatar Oct 08 '22 21:10 breck7

Thanks a lot @breck7 , I will work on this.

mahadwaseem123 avatar Oct 08 '22 21:10 mahadwaseem123

Screenshot 2022-10-10 at 4 17 33 PM Screenshot 2022-10-10 at 4 17 57 PM

mahadwaseem123 avatar Oct 10 '22 11:10 mahadwaseem123

Hi @breck7 , I attached some screenshots for your reference.

mahadwaseem123 avatar Oct 10 '22 11:10 mahadwaseem123

related issue ? https://github.com/breck7/pldb/issues/220

Should certain keys like compilesTo, type and featureKeyword be treated specially ?? they could to act like tags for searching and enhance the end user experience, how will the grammer definition represent this ??

ghost avatar Oct 15 '22 02:10 ghost

I'm going to close this for now and reopen later

breck7 avatar Jan 14 '23 15:01 breck7