Brecht Sanders

Results 270 comments of Brecht Sanders

I usually do: ``` if ((s = (char*)malloc(wantedsize)) == NULL) return NULL; //or some error code ``` that way you don't assume malloc worked causing the application to crash or...

Styles are numbered. That's why I was wondering why hashing was used. A (sparse) array structure would do for this. But I guess it will do for now. Worst case...

Wow, you're quick! I avoid camelCase in pure C. I stick with lower case and use underscore to separate things that are separate (e.g. get_numberformat).

For me MinGW in Windows is my primary development platform, but I also make sure it builds on Debian Linux and macOS. MiniZip 1.2.8 (downloaded from http://www.gaia-gis.it/gaia-sins/dataseltzer-sources/) builds fine on...

`FindEXPAT.cmake` is part of CMake, why do you rewrite it in your pull request? Also, what is the reason the line: ``` INCLUDE_DIRECTORIES(${EXPAT_INCLUDE_DIRS}) ``` was changed to: ``` INCLUDE_DIRECTORIES(${EXPAT_INCLUDE_DIR}) ```...

Wouldn't it make more sense to report to the CMake developer(s) that `FindEXPAT.cmake` needs some tweaking for debug builds on Windows? `FindEXPAT.cmake` contains: ```cmake if(EXPAT_FOUND) set(EXPAT_LIBRARIES ${EXPAT_LIBRARY}) set(EXPAT_INCLUDE_DIRS ${EXPAT_INCLUDE_DIR}) ```...

gprof is part of binutils, of which version 2.39 was recently released. You can check if you're still using an older version with: `gprof --version` Also GCC 11.3.0 is not...

I actually get the same output as you with the latest release: ```bash gcc -pg -g -O0 -c -o a.o a.c && gcc -pg -g a.o -o a.exe && ./a.exe...

The `win32` builds use the Windows threads API as much as possible but don't provide POSIX threads compatibility (`pthreads.h`). In the winlibs project it was decided there is no benefit...

I don't see how this relates to Win32 threads. For the winlibs build it was decided to only make POSIX thread releases as these also provide Win32 threads support and...