Laravel 8 support, Jira v3 API compatibility, Fix paginate request with query params, Fix naming collision with jwt-auth.

[henritoivar]

Updated dependencies to support Laravel 8. Updated Jira Paginator to use v3 API conventions. Fixed query parameters being overwritten by default pagination parameters, when providing query parameters to $client->paginate. Made guard name and middleware name more specific to avoid naming collision with tymon/jwt-auth. Ideally thiese two could be defined in the config?

[breart]

@henritoivar thanks for the contribution. If we add support for v3 API, v2 won't be longer supported. Would that be an issue?

I'll also add support for L7 in this PR since there is not a lot of changes between those.

[henritoivar]

I have added a few more adjustments:

• dispatcher fire method has been removed in laravel 5.8, use dispatch instead
• jira doesn't include user_key and user_id anymore in the request. See here: https://developer.atlassian.com/cloud/jira/platform/context-parameters/
• Also atlassian callbacks do not include the Accept header with value application/json. This will make Laravel redirect in case validation does not pass. I have overriden this behaviour so validation messages are always returned as json.

[henritoivar]

@henritoivar thanks for the contribution. If we add support for v3 API, v2 won't be longer supported. Would that be an issue?

I'll also add support for L7 in this PR since there is not a lot of changes between those.

I use only v3, so it's not a problem for me.

[leganz]

Are there any plans to integrate that PR into master? It would be pretty nice, cause i have laravel 8 project which would benefit from that :-)

[mystiquewolf]

@henritoivar Is it possible/reasonable for me to manually merge this pull request locally so i can use this in Laravel 8, is it stable enough in your opinion?

[henritoivar]

@mystiquewolf I'm using this in production myself. So far no issues.

Until this gets merged you could use my fork (or fork my fork.. hehe) directly like this in your composer.json:

"require": {
  "brezzhnev/atlassian-connect-core": "dev-master",
  ...
},
"repositories": {
   {
       "type": "vcs",
       "url": "https://github.com/henritoivar/atlassian-connect-core"
   }
}

[breart]

Sorry guys for abandoning this repo, I can't manage to find time to maintain and improve this package. I'm happy to invite someone as a collaborator on this project, making sure every change gets tested and follows the project coding style.

Please send an email to [email protected] if you're interested.