breadboard icon indicating copy to clipboard operation
breadboard copied to clipboard

`property-1` on input and `runJavascript` and unable to change the id

Open PaulKinlan opened this issue 1 year ago • 6 comments

https://github.com/breadboard-ai/breadboard/assets/45510/6d44a1a7-146b-4820-bcf8-626ed154d691

If I add a new input to the board, and then add a new port and name it title and then I add a runJavascript and connect it to the * port it comes out as property-1 with no way to change the name in the UI. It's pretty inconvenient to use this in the code in runJavaScript.

  1. I'd expect it to be the same name as the connecting port.
  2. I'd expect to be able to change it.

PaulKinlan avatar May 22 '24 21:05 PaulKinlan

Use the new ad hoc wiring hotness! Instead of dragging it into the "*" wire, just drag it onto runJavascript node, wait for it to light up orange, and drop -- it will ask you to name the output.

dglazkov avatar May 22 '24 22:05 dglazkov

Another reason to bump #1849 in priority.

dglazkov avatar May 22 '24 22:05 dglazkov

Yeah - I saw that too, can we auto-fill the text name in that popup too. I'd like to just press enter when it's obvious.

PaulKinlan avatar May 23 '24 10:05 PaulKinlan

I'm not sure I know what it should be by default, but I'd be happy to pre-fill the input. Do you have any suggestions?

paullewis avatar May 23 '24 10:05 paullewis

Same name as the origin port?

PaulKinlan avatar May 23 '24 12:05 PaulKinlan

Okay, I can do that

paullewis avatar May 23 '24 13:05 paullewis

Fixed in 85f023d751977318424b794bef5b009204923d84, with an additional boost from #1989

paullewis avatar May 30 '24 13:05 paullewis