Michael Ennen

Results 178 comments of Michael Ennen
trafficstars

To attempt to clarify: here is some code from NeonGroupable.swift: ``` swift case .Bottom: if group == .Horizontal { xOrigin = (self.width - (CGFloat(views.count) * width) - (CGFloat(views.count - 1)...

Sorry to hear that you have been sick :(. Here's the implementation of groupAgainstEdge that would allow one to specify both x and y padding individually so that we are...

Have there been some changes to mouse click privileges in Mojave? This may be an issue with the native Robot implementation in JavaFX on macOS. If that's the case I...

Honestly I haven't really felt comfortable with moving out of `alpha` because I am not entirely sure what @hastebrot 's intentions were in this regard. In my opinion the `alpha`...

TestFX supports Java 11 now (at least what's on `master` does) so number one is done. Still investigating number two.

Do you mind fixing the lint issues? ``` [ant:checkstyle] [ERROR] /home/travis/build/TestFX/TestFX/subprojects/testfx-core/src/main/java/org/testfx/robot/impl/MouseRobotImpl.java:38:11: 'static' modifier out of order with the JLS suggestions. [ModifierOrder] [ant:checkstyle] [ERROR] /home/travis/build/TestFX/TestFX/subprojects/testfx-core/src/main/java/org/testfx/robot/impl/MouseRobotImpl.java:38:31: Name 'mouseActionDurationMillis' must match pattern '^[A-Z][A-Z0-9]*(_[A-Z0-9]+)*$'....

This could be a result of improper scaling/HiDPI support? I contributing moving the JavaFX robot to the public API https://openjfx.io/javadoc/12/javafx.graphics/javafx/scene/robot/Robot.html so any PRs to fix it would be well received...

Certainly looks like a JavaFX + Monocle + Prism bug. Would be swell for upstream to reproduce without TestFX dependency.

Honestly I'm not sure. It seems to be some sort of concurrent access issue where maybe something isn't being done on the main JavaFX application thread? Really hard to tell...

The test appears to work as intended. In other words, I couldn't reproduce the failure.