braze-flutter-sdk icon indicating copy to clipboard operation
braze-flutter-sdk copied to clipboard

adding message type, and making sure message type doesn't get overriden

Open EssentialsDev opened this issue 1 year ago • 3 comments

The "html" message type was missing causing "slideup" to get returned.

Also when using the "full" type it would loop thru to the "html_full" and return that since it ends with "full"

EssentialsDev avatar Jan 16 '24 17:01 EssentialsDev

Hi @hokstuff, just seeing if this is something you're looking to review and merge anytime soon? Thank

WillNeill avatar Mar 26 '24 08:03 WillNeill

Hi, so I fully understand this proposed change, can you add more context in what the expected behavior is as well as the actual behavior you are seeing? Can you also attach the campaign you are using that you're running into issues with? (If you're more comfortable, feel free to contact [email protected] with the information)

I have some concerns with the code that is added, so I would like to understand the root of the problem and then make the change internally: Re: This line - Rather than use the endsWith, it probably would be more accurate to compare each string directly

hokstuff avatar Mar 26 '24 16:03 hokstuff

@hokstuff the key problem was that our marketing team was using the MessageType.html which isn't supported in the flutter project. The addition of the break was because full and html_full both end in "full" so if you are using the MessageType full it will still iterate thru the for loop and end up changing messageType to html_full when that is not expected.

I tried to make as little of a change as possible let me know if there is anything I should change.

We ended up using parts of the Android library instead, so I apologize for the delay in my response.

EssentialsDev avatar Jun 20 '24 03:06 EssentialsDev