PerformanceAnalytics icon indicating copy to clipboard operation
PerformanceAnalytics copied to clipboard

Gsoc 2021

Open jaindhairyahere opened this issue 2 years ago • 1 comments

This PR adds the Robust SFM functionality to PerfA!

jaindhairyahere avatar Jul 31 '22 20:07 jaindhairyahere

There is a conflict in only the R-CMD-check file, which is I think related to integration with github and is a part of CI/CD pipeline.

jaindhairyahere avatar Jul 31 '22 21:07 jaindhairyahere

@jaindhairyahere It appears there are a few errors here picked up by Github actions check. Here is the first:

  >     SFM.alpha(managers[,1:3], managers[,8:10], Rf=.035/12) 
       Alpha : SP500 TR Alpha : US 10Y TR Alpha : US 3m TR
  HAM1            0.006             0.009            0.008
  HAM2            0.009             0.011            0.010
  HAM3            0.006             0.010            0.008
  >     SFM.alpha(managers[,1], managers[,8:10], Rf=.035/12, benchmarkCols=F) 
  Error in processResults(result.all, "intercept", Ra.ncols, Rb.ncols, Ra.colnames,  : 
    **F used instead of FALSE**

It appears, you need to change the benchmarkCols=F to benchmarkCols=FALSE

Please run CMD Check locally in the build tab (if using RStudio) and fix associated errors.

JustinMShea avatar Oct 13 '22 22:10 JustinMShea

@jaymon0703 You may want to review as well :)

JustinMShea avatar Oct 13 '22 22:10 JustinMShea

Thanks @JustinMShea I left a comment here on the previous PR which was closed. Let us know @jaindhairyahere if you cannot resolve the errors. Not sure about the necessity for solving Warnings and Notes but get the Errors out the way first.

jaymon0703 avatar Oct 14 '22 00:10 jaymon0703