browser-laptop icon indicating copy to clipboard operation
browser-laptop copied to clipboard

read.amazon.com doesn't support Brave browser

Open swaroopch opened this issue 7 years ago • 4 comments

  • Did you search for similar issues before submitting this one? Yes

  • Describe the issue you encountered: screenshot from 2017-03-22 06-25-38

  • Platform (Win7, 8, 10? macOS? Linux distro?): Ubuntu 16.10

  • Brave Version (revision SHA): 0.13.5 / 1db81cb

  • Steps to reproduce:

    1. Visit https://read.amazon.com
    2. Click yes to making app available offline
  • Actual result: Unsupported browser. Use Chrome, etc.

  • Expected result: Start reading Kindle books in browser.

  • Will the steps above reproduce in a fresh profile? If not what other info can be added? Yes

  • Is this an issue in the currently released version? Yes

  • Can this issue be consistently reproduced? Yes

  • Extra QA steps: 1. 2. 3.

  • Screenshot if needed: Above

  • Any related issues:

swaroopch avatar Mar 22 '17 13:03 swaroopch

I'm not immediately able to repro on 0.14.0 (https://github.com/brave/browser-laptop/commit/64b381abf3cbe91ec6ff007035c13100102d617b). That being said, there is still an issue. The Enable Offline button makes an attempt to do an inline installation of the Kindle Cloud Reader extension.

<link rel='chrome-webstore-item' href='https://chrome.google.com/webstore/detail/icdipabjmbhpdkjaihfjoikhjjeneebd'/>

The actual installation is triggered by the following:

KindleChromeInstaller = function() {
    function a() {
        function a() {
            window.location.reload(!1)
        }
        Kindle.top.chrome.webstore.install(void 0, function() {
            KindleDebug.log("install success");
            setTimeout(a, 250)
        }, function(a) {
            KindleDebug.error(a)
        })
    }
    function f() {
        return window.chrome && Kindle.top.chrome.webstore && Kindle.top.chrome.webstore.install
    }
    return {
        install: function() {
            f() ? window.parent.document.getElementById("inlineInstallProxy").click() : KindleMessageDialog.showError(Kindle.ERROR.OUTDATED_CHROME)
        },
        initialize: function() {
            if (KindleHostDeviceDetector.isChrome() && f()) {
                var d = document.createElement("button");
                d.id = "inlineInstallProxy";
                d.style.display = "none";
                $(d).click(a);
                $("body").append(d)
            }
        }
    }
}()

We may be able to clear this issue by simply supporting the Kindle Cloud Reader extension. I will turn my attention there next.

jonathansampson avatar Mar 22 '17 21:03 jonathansampson

I ran into this issue this evening. Earlier today the read.amazon.ca worked without any issues, then this evening I went back to the site (after a browser restart and Mac in sleep for a while) and I am now getting the same warning. (I hit "no" to the offline reading option).

If I open inspector, the console shows "Application loaded from Cache with manifest..." if I then goto the Application tab in developer tools, ensure everything is checked and press "Clear site data" then refresh the page loads without any issues.

Brave 0.14.1 OS Mac OS X (10.12.4)

butlermatt avatar Apr 14 '17 00:04 butlermatt

Appears to still be an issue: https://twitter.com/fpoling/status/929407354101288965

jonathansampson avatar Nov 11 '17 18:11 jonathansampson

If I open inspector, the console shows "Application loaded from Cache with manifest..." if I then goto the Application tab in developer tools, ensure everything is checked and press "Clear site data" then refresh the page loads without any issues.

Was running into this issue and the above solved it.

colinschindler avatar Feb 26 '18 12:02 colinschindler