brave-ui icon indicating copy to clipboard operation
brave-ui copied to clipboard

Large SVGs in Rewards should be external asset

Open petemill opened this issue 5 years ago • 0 comments

There are some large ~50kb assets that are included in the bundle. These would benefit from being external assets to consuming bundle sizes (especially valid on Android).

Inline SVGs are very useful when they are component-like, or for some other reason need to be styled with CSS. These assets seem like graphics and therefore do not need to be included. If they did, then I would suggest using import() or React.lazy() syntax so that they are contained in a different JS file.

petemill avatar Nov 05 '18 22:11 petemill