brave-ui icon indicating copy to clipboard operation
brave-ui copied to clipboard

Button component is not easy to extend

Open cezaraugusto opened this issue 6 years ago • 2 comments

trying to apply styled() to buttons is not straight-forward. It should be easy enough to just apply the new styles without worrying about TypeScript definitions or thinking too much.

this needs investigation for details but for now I opened this w/ tracking purposes

cezaraugusto avatar Sep 24 '18 17:09 cezaraugusto

@cezaraugusto can you provide an example which requires too much thinking?

petemill avatar Sep 24 '18 17:09 petemill

@cezaraugusto I extended button quite easy. I did it like this: https://github.com/brave/brave-ui/blob/master/src/features/rewards/modalAddFunds/style.ts#L88

NejcZdovc avatar Sep 24 '18 17:09 NejcZdovc