brave-ui icon indicating copy to clipboard operation
brave-ui copied to clipboard

Theme Containers

Open petemill opened this issue 5 years ago • 1 comments

Goals

  • Allow user to select dark and light
  • Allow designer to specify always-dark areas

Needs

  • Know which areas can change between dark and light
  • Know which areas are always-dark
  • Know which areas are always-light

Method

  • Each core component needs to be able to be dark or light.
  • Each layout area needs to specify whether it is:
    • Changeable to dark and light
      • child components
      • background
    • Always dark
    • Always light

petemill avatar Sep 12 '18 03:09 petemill

Here's what this proposal could look like:

<ThemeContainer user-choice>
   ...stuff that can be dark or light with one of the 'standard' theme backgrounds...
  <ThemeContainer always-dark style="background: [something custom]">
     …stuff that is always in 'dark theme'… 
  </ThemeContainer>
   ...stuff that can be dark or light with one of the 'standard' theme backgrounds...
</ThemeContainer>

petemill avatar Feb 06 '19 20:02 petemill