brave-ios
brave-ios copied to clipboard
Add ability to reveal wallet password on unlock
Description:
We should add a button/toggle to show/hide password
ref: https://bravesoftware.slack.com/archives/C023VS4HJ6Q/p1666185103959729 ref #2: https://bravesoftware.slack.com/archives/C023VS4HJ6Q/p1695925899009109?thread_ts=1695912331.946559&cid=C023VS4HJ6Q
https://www.figma.com/file/oXIiv45pIhF2RGlpEjOfUg/Wallet-onboarding?type=design&node-id=6234%3A45645&mode=design&t=WgEPNGFw5QmUuWZ1-1
Verified on iPhone 14
and iPad Air
using version(s):
Device/OS: iPhone 14 [iOS 16.4.1] and iPad Air [iPadOS 16.4.1]
Version: 1.51 (23.5.8.16)
BraveCore: 1.51.110 (113.0.5672.77)
Filed follow-up issue #7416
3rd-party keyboard - FAIL
PRECONDITIONS:
- Install a 3rd-party keyboard, for example,
Gboard
STEPS:
Create Wallet
- Launch Brave > Three dot Menu > Wallet
- Get Started > Tap in the
Password
field > Verify that Apple keyboard is shown - Tap and hold Globus thumbnail > Verify there is no option to show
Gboard
- Verify the same for the
Verify password
field
Unlock
- Launch Brave > Three dot Menu > Wallet
- Tap in the
Password
field > Verify that Apple keyboard is showing - Tap and hold Globus thumbnail > Verify there is no option to show
Gboard
Restore
- Launch Brave > Three dot Menu > Wallet
- Tap
Restore
Tap in theRecovery Phrase
field > Verify that Apple keyboard is showing - Tap and hold Globus thumbnail > Verify there is no option to show
Gboard
- Repeat the same for the
Password
andVerify password
text fields
ACTUAL RESULTS:
- Verified that 3rd-party keyboard is not shown for the text fields on the
Create
(setup new wallet),Unlock
andRestore
screens
1 | 2 | 3 |
---|---|---|
![]() |
![]() |
![]() |
Password reveal/hide - PASS
STEPS:
- Launch Brave > Three dot Menu > Wallet
- Get Started > Tap in the
Password
field > Type password > TapEye thumbnail
> Verify - Repeat the same for the
Verify password
text field
ACTUAL RESULTS:
- Verified that the password is revealed when the Eye thumbnail is tapped, and hidden when the Crossed-eye thumbnail is tapped
https://user-images.githubusercontent.com/128532965/236957191-bcf1eaa3-afcd-47af-9798-ccaac8163394.mov
Biometric unlock - PASS
STEPS:
- Launch Brave > Three dot Menu > Wallet
- Use Biometric unlock > Verify
ACTUAL RESULTS:
- Verified that auto-filling password via biometrics is hiding/masking the password before auto-filling it.
https://user-images.githubusercontent.com/128532965/236957942-fc95a1f7-4803-43ef-b541-256982cdc26e.mov
Filed follow-up issue https://github.com/brave/brave-ios/issues/7416