brave-ios icon indicating copy to clipboard operation
brave-ios copied to clipboard

Cosmetic filter scripts not applied during an HTTPS upgrade

Open cuba opened this issue 2 years ago • 0 comments

Description:

During an upgrade from http to https cosmetic filters are not applied.

Steps to Reproduce

  1. Enabled cookie consent blocking filter list
  2. Go to stackoverflow.com (i.e. omit the https) or explicitly to http://stackoverflow.com
  3. Will get redirected to https://stackoverflow.com

Actual result: Cookie consent dialogue is present

Expected result: Cookie consent dialogue should be gone

Reproduces how often: [Easily reproduced, Intermittent Issue] Easily reproduced

Brave Version: 1.4.4

Device details: Any

Website problems only:

  • did you check with Brave Shields down?
  • did you check in Safari/Firefox (WkWebView-based browsers)?

Additional Information

Happens because we load the scripts for http then we look for https url to execute it.

cuba avatar Oct 05 '22 11:10 cuba