brave-ios
brave-ios copied to clipboard
Fix #1358: Cookie consent blocking
Summary of Changes
This will add a setting to Shields to enable cookie consent notices It will also show a popup on second launch to allow the user to know this feature is available
This pull request fixes #1358
Submitter Checklist:
- [ ] Unit Tests are updated to cover new or changed functionality
- [x] User-facing strings use
NSLocalizableString()
- [x] New or updated UI has been tested across:
- [x] Light & dark mode
- [x] Different size classes (iPhone, landscape, iPad)
- [x] Different dynamic type sizes
Test Plan:
Make sure that
When the user clicks on "Yes block cookie consent notices" on the popup:
- [ ] The setting is enabled in shields
- [ ] The cookie notice blocking filter list is enabled
- [ ] The animation plays and then the popup disappears
When the user clicks on "No thanks" on the popup
- [ ] The setting is not enabled in shields
- [ ] The cookie notice blocking filter list is not enabled
- [ ] The popup is dismissed
When the setting is enabled:
- [ ] The popup doesn't appear on second launch (Note: you will need to enabled it on first launch)
- [ ] The cookie consent notices are blocked
When the setting is not enabled:
- [ ] The popup appears on a second launch (note that depending on timing other full screen popups might appear in priority)
- [ ] Cookie consent notices are not blocked
Persistence
- [ ] Test for synchronization between the cookie blocking setting in shields and the filter list is enabled in filter lists screen
- [ ] Test for persistence (setting is held) when the app is terminated
Screenshots:
Reviewer Checklist:
- [ ] Issues include necessary QA labels:
-
QA/(Yes|No)
-
bug
/enhancement
-
- [ ] Necessary security reviews have taken place.
- [ ] Adequate unit test coverage exists to prevent regressions.
- [ ] Adequate test plan exists for QA to validate (if applicable).
- [ ] Issue and pull request is assigned to a milestone (should happen at merge time).
I have another question. are we supposed to show this pop-up for new users ?
Most of my comments are still unaddressed