Auto Close Tabs Reorders Them Strangely

[buthed010203]

Description:

The auto close tabs feature tends to shuffle my tabs when I open the browser. It's been happening for months and somehow I seem to be the only one with this problem.

Steps to Reproduce

1. Open a bunch of tabs
2. Wait a day or so
3. Turn on Auto Close (I don't know if it works when it was originally on and I don't feel like compiling this from scratch or spending days on this issue)
4. Reopen the app, some tabs will close while others will be shuffled I'm not doing anything else which is why I'm curious as to how no one else has this issue.

Actual result: Stale tabs are closed, remaining tabs are shuffled at random. Never thought to take a screen recording, I will next time it happens.

Expected result: Stale tabs are closed, remaining tabs retain their order.

Reproduces how often: I've tried it about 10 times over the last few months on various different versions and the problems are the same every time. It's consistent on my end but I'm not sure if its device specific.

Brave Version: v1.33 (21.12.14.16), works on all of the older versions that I've tried as well.

Device details: iPhone 11, iOS 15.0.1

Additional Information

I tried to find the culprit myself but I don't know a thing about swift and all the code I looked over was seemingly fine.

[soner-yuksel]

I really cant reproduce this issue. I tried every possible way and every-time remaining tabs preserved their index.

As far I researched the implementation this behaviour really doesn't seem possible except Int overflow might happen for tab index. But for Int16 to overflow, user has to have more than 32767 tabs which doesn't seem likely to happen.

Leaving a ticket open for now since I cant reproduce this behaviour.