brave-ios icon indicating copy to clipboard operation
brave-ios copied to clipboard

Don't exclude Downloads from backups

Open ViRb3 opened this issue 3 years ago • 1 comments

Description:

I just switched phones, restored my backup, wiped the old phone, just to find that all the files I had downloaded were missing. Looking at this GitHub repo, I found issue #1438 and then PR #1455 that marks the Download folder as excluded from backups.:

https://github.com/brave/brave-ios/blob/a2865d38dd582ff8829c56ca0fe973621e6ae181/Client/FileManagerExtension.swift#L20-L21

May I know why this is the case? I agree that it is my fault for not checking before, but I did not anticipate this "feature". All other browsers such as Safari do not exclude their Downloads from backups. On Safari, the folder can be found under:

Apps\com.apple.mobilesafari\Container\Library\Safari\Downloads

Could the Downloads folder please be included back into backups?

Thanks

Reproduces how often: Always

Brave Version: 1.24(21.4.1.15)

Device details: iPhone 12, iOS 14.5.1

ViRb3 avatar May 08 '21 20:05 ViRb3

The download folder seems to be still excluded from backups for the current iOS version of Brave. Please include if for backups as it is included e.g. for safari.

tilfischer avatar Nov 04 '23 14:11 tilfischer