brave-core icon indicating copy to clipboard operation
brave-core copied to clipboard

use jest-fail-on-console to fail on warnings

Open arthuredelstein opened this issue 10 months ago • 2 comments

Resolves https://github.com/brave/brave-browser/issues/47221

(Need to merge https://github.com/brave/brave-browser/issues/47219 as well to fix the DeleteAliasModal warning)

arthuredelstein avatar Jun 27 '25 17:06 arthuredelstein

Warning

You have got a presubmit warning. Please address it if possible.

Found 5 lines longer than 80 characters (first 5 shown).

Items:

components/ai_chat/resources/page/components/input_box/index.test.tsx, line 43, 124 chars
components/ai_chat/resources/page/components/input_box/index.test.tsx, line 63, 95 chars
components/ai_chat/resources/page/components/input_box/index.test.tsx, line 70, 129 chars
components/ai_chat/resources/page/components/input_box/index.test.tsx, line 97, 105 chars
components/ai_chat/resources/page/components/input_box/index.test.tsx, line 117, 104 chars

I will fix these warnings before merging (done).

arthuredelstein avatar Jun 27 '25 19:06 arthuredelstein

A Storybook has been deployed to preview UI for the latest push

brave-builds avatar Jun 27 '25 19:06 brave-builds

Chromium major version is behind target branch (138.0.7204.49 vs 139.0.7258.32). Please rebase.

github-actions[bot] avatar Jul 16 '25 20:07 github-actions[bot]

Looks like the security/privacy review was passed, but we didn't merge this PR in. I'm going to close this out as stale at this point, we can pick it up later if needed.

ShivanKaul avatar Oct 17 '25 17:10 ShivanKaul