brave-core
brave-core copied to clipboard
Show which tabs are unloaded
Introduces Edge's simple and intuitive behavior in which unloaded tabs are distinguished from loaded tabs. This behavior replaces Chromium's behavior in which unloaded tabs are not distinguished from loaded tabs except where a tab is proactively discarded.
Resolves https://github.com/brave/brave-browser/issues/36720.
I checked this PR locally. It is working. Your developer config however appears to be broken and so a few tests for unrelated things fail.
Submitter Checklist:
- [x] I confirm that no security/privacy review is needed and no other type of reviews are needed, or that I have requested them
- [x] There is a ticket for my issue
- [x] Used Github auto-closing keywords in the PR description above
- [x] Wrote a good PR/commit description
- [ ] Squashed any review feedback or "fixup" commits before merge, so that history is a record of what happened in the repo, not your PR
- [ ] Added appropriate labels (
QA/Yes
orQA/No
;release-notes/include
orrelease-notes/exclude
;OS/...
) to the associated issue - [x] Checked the PR locally:
- [ ] Ran
git rebase master
(if needed)
Reviewer Checklist:
- [ ] A security review is not needed, or a link to one is included in the PR description
- [ ] New files have MPL-2.0 license header
- [ ] Adequate test coverage exists to prevent regressions
- [ ] Major classes, functions and non-trivial code blocks are well-commented
- [ ] Changes in component dependencies are properly reflected in
gn
- [ ] Code follows the style guide
- [ ] Test plan is specified in PR before merging
After-merge Checklist:
- [ ] The associated issue milestone is set to the smallest version that the changes has landed on
- [ ] All relevant documentation has been updated, for instance:
- [ ] https://github.com/brave/brave-browser/wiki/Deviations-from-Chromium-(features-we-disable-or-remove)
- [ ] https://github.com/brave/brave-browser/wiki/Proxy-redirected-URLs
- [ ] https://github.com/brave/brave-browser/wiki/Fingerprinting-Protections
- [ ] https://github.com/brave/brave-browser/wiki/Brave%E2%80%99s-Use-of-Referral-Codes
- [ ] https://github.com/brave/brave-browser/wiki/Web-Compatibility-Exceptions-in-Brave
- [ ] https://github.com/brave/brave-browser/wiki/QA-Guide
- [ ] https://github.com/brave/brave-browser/wiki/P3A
Test Plan:
- Restore a session so that we'll have unloaded tabs that weren't discarded.
- Visit
brave://discards
. - Click
Urgent Discard
for a tab. - Click
Proactive Discard
for another tab. - Right click
Tab Discard (Suspender)
and selectDiscard active tab only
. - Click
Tab Discard (Suspender)
in another tab to externally discard it and quickly switch away to avoid reloading. - Unloaded tabs should be visually distinguishable instead of just proactively discarded tabs.