brave-core icon indicating copy to clipboard operation
brave-core copied to clipboard

Serialize Page Graph args as json.

Open goodov opened this issue 1 year ago • 6 comments

PageGraph Version 0.4.0

Better handling of WebAPI values

WebAPI values are now serialized more effectively. It includes all the properties of objects, even the ones that are not easily visible. This makes it similar to how DevTools handles object properties.

The EdgeJSCall::args is now a JSON array that contains all the observed arguments. The EdgeJSResult::result is also a JSON value.

Improved tracking of Console API

The Console built-in functionality in V8 is now being tracked. This means that all console.* APIs will be visible in the graph as JSBuiltin ConsoleLog, ConsoleWarn, and similar.

The console.log WebAPI has been renamed to ConsoleMessageAdded to better represent its tracking functionality. However, it may not appear in most graphs as it is usually not bound to an acting script, and such calls are currently ignored in the graph.

Expanded tracking of APIs

The Geolocation and MediaDevices WebAPIs are now being tracked.

Resolves https://github.com/brave/brave-browser/issues/35130

Submitter Checklist:

  • [x] I confirm that no security/privacy review is needed and no other type of reviews are needed, or that I have requested them
  • [x] There is a ticket for my issue
  • [x] Used Github auto-closing keywords in the PR description above
  • [x] Wrote a good PR/commit description
  • [ ] Squashed any review feedback or "fixup" commits before merge, so that history is a record of what happened in the repo, not your PR
  • [ ] Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • [ ] Checked the PR locally:
    • npm run test -- brave_browser_tests, npm run test -- brave_unit_tests wiki
    • npm run presubmit wiki, npm run gn_check, npm run tslint
  • [ ] Ran git rebase master (if needed)

Reviewer Checklist:

  • [ ] A security review is not needed, or a link to one is included in the PR description
  • [ ] New files have MPL-2.0 license header
  • [ ] Adequate test coverage exists to prevent regressions
  • [ ] Major classes, functions and non-trivial code blocks are well-commented
  • [ ] Changes in component dependencies are properly reflected in gn
  • [ ] Code follows the style guide
  • [ ] Test plan is specified in PR before merging

After-merge Checklist:

  • [ ] The associated issue milestone is set to the smallest version that the changes has landed on
  • [ ] All relevant documentation has been updated, for instance:
    • [ ] https://github.com/brave/brave-browser/wiki/Deviations-from-Chromium-(features-we-disable-or-remove)
    • [ ] https://github.com/brave/brave-browser/wiki/Proxy-redirected-URLs
    • [ ] https://github.com/brave/brave-browser/wiki/Fingerprinting-Protections
    • [ ] https://github.com/brave/brave-browser/wiki/Brave%E2%80%99s-Use-of-Referral-Codes
    • [ ] https://github.com/brave/brave-browser/wiki/Web-Compatibility-Exceptions-in-Brave
    • [ ] https://github.com/brave/brave-browser/wiki/QA-Guide
    • [ ] https://github.com/brave/brave-browser/wiki/P3A

Test Plan:

goodov avatar Feb 27 '24 13:02 goodov