brave-core
brave-core copied to clipboard
Windows arm64 support (sans Widevine)
Resolves https://github.com/brave/brave-browser/issues/6319. Widevine is not yet supported.
Test plan
This change updates Brave's auto-updater on Windows and thus has the potential to break Brave's installers and entire update fleet on Windows. It is therefore very important to re-test these features once this issue is resolved. Please see https://github.com/brave/brave-core/pull/11096 for a test plan.
Submitter Checklist:
- [x] I confirm that no security/privacy review is needed, or that I have requested one
- [x] There is a ticket for my issue
- [x] Used Github auto-closing keywords in the PR description above
- [x] Wrote a good PR/commit description
- [ ] Squashed any review feedback or "fixup" commits before merge, so that history is a record of what happened in the repo, not your PR
- [x] Added appropriate labels (
QA/Yes
orQA/No
;release-notes/include
orrelease-notes/exclude
;OS/...
) to the associated issue - [ ] Checked the PR locally:
npm run test -- brave_browser_tests
,npm run test -- brave_unit_tests
,npm run lint
,npm run gn_check
,npm run tslint
- [ ] Ran
git rebase master
(if needed)
Reviewer Checklist:
- [ ] A security review is not needed, or a link to one is included in the PR description
- [ ] New files have MPL-2.0 license header
- [ ] Adequate test coverage exists to prevent regressions
- [ ] Major classes, functions and non-trivial code blocks are well-commented
- [ ] Changes in component dependencies are properly reflected in
gn
- [ ] Code follows the style guide
- [ ] Test plan is specified in PR before merging
After-merge Checklist:
- [ ] The associated issue milestone is set to the smallest version that the changes has landed on
- [ ] All relevant documentation has been updated, for instance:
- [ ] https://github.com/brave/brave-browser/wiki/Deviations-from-Chromium-(features-we-disable-or-remove)
- [ ] https://github.com/brave/brave-browser/wiki/Proxy-redirected-URLs
- [ ] https://github.com/brave/brave-browser/wiki/Fingerprinting-Protections
- [ ] https://github.com/brave/brave-browser/wiki/Brave%E2%80%99s-Use-of-Referral-Codes
- [ ] https://github.com/brave/brave-browser/wiki/Custom-Headers
- [ ] https://github.com/brave/brave-browser/wiki/Web-Compatibility-Exceptions-in-Brave
- [ ] https://github.com/brave/brave-browser/wiki/QA-Guide
- [ ] https://github.com/brave/brave-browser/wiki/P3A
Awesome! I'm excited for this! \o/
Nice! Is there any plan for windows arm64 release?
@nsait-linaro one nightly release per day will have the binaries just like https://github.com/brave/brave-browser/releases/tag/v1.47.33
Thanks @mihaiplesa. I tried the nightly pre-release packages and seem to work well!
I guess the official v1.47 release will contain the windows arm64 binaries as well?
If you mean release/stable channel then ARM64 support will reach it in December/January.
Does anyone know why Windows Arm64 packages are only available on some 1.47.x release builds?
For example, https://github.com/brave/brave-browser/releases/tag/v1.47.104 release doesn't have Windows Arm64 package. The last 1.47.x release with Windows Arm64 package seems to be https://github.com/brave/brave-browser/releases/tag/v1.47.97
@nsait-linaro that's intended since the code is not in 1.46.x yet. It will be next month and that's when release channel will get arm64 support.