brave-core
brave-core copied to clipboard
Don't show payment status banner in rewards summary on settings page
Resolves https://github.com/brave/brave-browser/issues/24584 Resolves https://github.com/brave/brave-browser/issues/24642
Submitter Checklist:
- [x] I confirm that no security/privacy review is needed, or that I have requested one
- [x] There is a ticket for my issue
- [x] Used Github auto-closing keywords in the PR description above
- [x] Wrote a good PR/commit description
- [x] Squashed any review feedback or "fixup" commits before merge, so that history is a record of what happened in the repo, not your PR
- [x] Added appropriate labels (
QA/Yes
orQA/No
;release-notes/include
orrelease-notes/exclude
;OS/...
) to the associated issue - [x] Checked the PR locally:
npm run test -- brave_browser_tests
,npm run test -- brave_unit_tests
,npm run lint
,npm run gn_check
,npm run tslint
- [x] Ran
git rebase master
(if needed)
Reviewer Checklist:
- [ ] A security review is not needed, or a link to one is included in the PR description
- [ ] New files have MPL-2.0 license header
- [ ] Adequate test coverage exists to prevent regressions
- [ ] Major classes, functions and non-trivial code blocks are well-commented
- [ ] Changes in component dependencies are properly reflected in
gn
- [ ] Code follows the style guide
- [ ] Test plan is specified in PR before merging
After-merge Checklist:
- [ ] The associated issue milestone is set to the smallest version that the changes has landed on
- [ ] All relevant documentation has been updated, for instance:
- [ ] https://github.com/brave/brave-browser/wiki/Deviations-from-Chromium-(features-we-disable-or-remove)
- [ ] https://github.com/brave/brave-browser/wiki/Proxy-redirected-URLs
- [ ] https://github.com/brave/brave-browser/wiki/Fingerprinting-Protections
- [ ] https://github.com/brave/brave-browser/wiki/Brave%E2%80%99s-Use-of-Referral-Codes
- [ ] https://github.com/brave/brave-browser/wiki/Custom-Headers
- [ ] https://github.com/brave/brave-browser/wiki/Web-Compatibility-Exceptions-in-Brave
- [ ] https://github.com/brave/brave-browser/wiki/QA-Guide
- [ ] https://github.com/brave/brave-browser/wiki/P3A
Test Plan:
STR included in issue description.
A Storybook has been deployed to preview UI for the latest push
A Storybook has been deployed to preview UI for the latest push
CI passed on everything but Windows and Linux; restarting on those platforms.
A Storybook has been deployed to preview UI for the latest push
Windows CI passed; rerunning Linux.
CI passed on all platforms; ready to merge.
Verification PASSED on
Brave | 1.44.52 Chromium: 104.0.5112.102 (Official Build) nightly (64-bit)
-- | --
Revision | 8e5396254975ef939f2ef7d0bd334e48a052b536-refs/branch-heads/5112@{#1478}
OS | Windows 10 Version 21H2 (Build 19044.1889)
Issue - #24584_PASSED
- Confirmed
payment status
banner is not shown on the rewards summary on setting page - Confirmed
payout pending
andpayout processing
messages are NOT shown in two different places at the same time - Confirmed
payout pending
banner message is shown in therewards settings page
,BR panel
,NTP
andBR panel on the website
unverified (non custodian connected)
Example | Example | Example | Example |
---|---|---|---|
![]() |
![]() |
![]() |
![]() |
Gemini custodian connected
Example | Example | Example | Example |
---|---|---|---|
![]() |
![]() |
![]() |
![]() |
Issue - #24642_PASSED
- Confirmed
payment status
banner is NOT shown on the rewards summary on setting page - Confirmed
payout pending
andpayout arrived
messages are NOT shown in two different places at the same time - Confirmed
payout pending
,payment processing
andpayment arrived
banner messages are shown in therewards settings page
,BR panel
,NTP
andBR panel on the website
Payment pending banner message_PASSED
Example | Example | Example | Example |
---|---|---|---|
![]() |
![]() |
![]() |
![]() |
Payment processing banner message_PASSED
Example | Example | Example | Example |
---|---|---|---|
![]() |
![]() |
![]() |
![]() |
Payment arrived banner message_PASSED
Example | Example | Example | Example |
---|---|---|---|
![]() |
![]() |
![]() |
![]() |