brave-core icon indicating copy to clipboard operation
brave-core copied to clipboard

Expire Brave Ads catalog after last_updated + ping [DO NOT MERGE]

Open tmancey opened this issue 2 years ago • 1 comments

Resolves https://github.com/brave/brave-browser/issues/23581

Submitter Checklist:

  • [x] I confirm that no security/privacy review is needed, or that I have requested one
  • [x] There is a ticket for my issue
  • [x] Used Github auto-closing keywords in the PR description above
  • [x] Wrote a good PR/commit description
  • [x] Squashed any review feedback or "fixup" commits before merge, so that history is a record of what happened in the repo, not your PR
  • [x] Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • [x] Checked the PR locally: npm run test -- brave_browser_tests, npm run test -- brave_unit_tests, npm run lint, npm run gn_check, npm run tslint
  • [x] Ran git rebase master (if needed)

Reviewer Checklist:

  • [ ] A security review is not needed, or a link to one is included in the PR description
  • [ ] New files have MPL-2.0 license header
  • [ ] Adequate test coverage exists to prevent regressions
  • [ ] Major classes, functions and non-trivial code blocks are well-commented
  • [ ] Changes in component dependencies are properly reflected in gn
  • [ ] Code follows the style guide
  • [ ] Test plan is specified in PR before merging

After-merge Checklist:

  • [ ] The associated issue milestone is set to the smallest version that the changes has landed on
  • [ ] All relevant documentation has been updated, for instance:
    • [ ] https://github.com/brave/brave-browser/wiki/Deviations-from-Chromium-(features-we-disable-or-remove)
    • [ ] https://github.com/brave/brave-browser/wiki/Proxy-redirected-URLs
    • [ ] https://github.com/brave/brave-browser/wiki/Fingerprinting-Protections
    • [ ] https://github.com/brave/brave-browser/wiki/Brave%E2%80%99s-Use-of-Referral-Codes
    • [ ] https://github.com/brave/brave-browser/wiki/Custom-Headers
    • [ ] https://github.com/brave/brave-browser/wiki/Web-Compatibility-Exceptions-in-Brave
    • [ ] https://github.com/brave/brave-browser/wiki/QA-Guide
    • [ ] https://github.com/brave/brave-browser/wiki/P3A

Test Plan:

See https://github.com/brave/brave-browser/issues/23581

tmancey avatar Jun 21 '22 21:06 tmancey

@evq this would revert https://github.com/brave/brave-browser/issues/20843, and the catalog would need to be refreshed after current time + ping with a new id server side for users to continue to see ads

tmancey avatar Jun 21 '22 21:06 tmancey

:warning: PR head is an unsigned commit commit: 348315e476207fc82c55c68c4fc3e087e7500c46 reason: unsigned Please follow the handbook to configure commit signing cc: @tmancey

github-actions[bot] avatar Jan 03 '23 13:01 github-actions[bot]

:warning: PR head is an unsigned commit commit: dc65736aa227130fbe4025cd6bf786f0c057c91e reason: unsigned Please follow the handbook to configure commit signing cc: @tmancey

github-actions[bot] avatar Jan 11 '23 20:01 github-actions[bot]

:warning: PR head is an unsigned commit commit: 97b8deea451de994406f0b74baa13ebc9dcb0be2 reason: unsigned Please follow the handbook to configure commit signing cc: @tmancey

github-actions[bot] avatar Jan 19 '23 14:01 github-actions[bot]

:warning: PR head is an unsigned commit commit: 1b14ec426dbc75931ef4c396141d85908a68b572 reason: unsigned Please follow the handbook to configure commit signing cc: @tmancey

github-actions[bot] avatar Feb 02 '23 14:02 github-actions[bot]

:warning: PR head is an unsigned commit commit: 0d1e12770d073193306766c7092a165481d472db reason: unsigned Please follow the handbook to configure commit signing cc: @tmancey

github-actions[bot] avatar Feb 07 '23 14:02 github-actions[bot]

:warning: PR head is an unsigned commit commit: 49f8fd543c9e118fea1dcdc8bd8baaf8392f6000 reason: unsigned Please follow the handbook to configure commit signing cc: @tmancey

github-actions[bot] avatar Feb 20 '23 13:02 github-actions[bot]