brave-browser icon indicating copy to clipboard operation
brave-browser copied to clipboard

[Shred] Tab and data not deleted when using 'App Close' for Auto Shred

Open Uni-verse opened this issue 1 year ago • 1 comments

Description

Tab and website data are not deleted with Auto Shred set to 'App Close'

Steps to reproduce

  1. Enable #brave-shred in Brave://flags, restart browser
  2. Set Auto Shred to App Close in Shields & Privacy settings
  3. Open a new tab, load any URL
  4. Open Manage Website Data to confirm website data
  5. In active tab, open Shields panel -> Shred Site Data, confirm Auto Shred is set to App Close
  6. Close/relaunch Brave
  7. Confirm active tab is removed
  8. Confirm website data is deleted in Manage Website Data settings page

Actual result

Tab and data not deleted after closing app

Expected result

Tab and data should be deleted after closing app

Reproduces how often

Easily reproduced

Brave version

1.69 (146)

Device/iOS version

iPhone 12 | iOS 17.5.1 - Reproducible

Affected browser versions

  • [ ] latest AppStore
  • [X] latest TestFlight
  • [X] previous TestFlight

Reproducibility

  • [ ] with Brave Shields disabled
  • [ ] in the latest version of mobile Safari

Miscellaneous information

No response

Uni-verse avatar Aug 15 '24 16:08 Uni-verse

Just a note that we want to release Shred in 1.70

ShivanKaul avatar Aug 27 '24 18:08 ShivanKaul

The above requires 1.71.117 or higher for 1.71.x verification 👍

kjozwiak avatar Oct 22 '24 19:10 kjozwiak

Verified on iPhone 14 and iPad Mini (6th gen) using version(s):

Device/OS: 
- iPhone 14 / iOS 17.7
- iPad Mini (6th gen) / iPadOS 18.0.1
Brave build: 1.71 (118)
BraveCore: 1.71.118 (130.0.6723.70)

STEPS:

  1. Follow the STR/TP from https://github.com/brave/brave-browser/issues/40484#issue-2468382530
  2. Verified

ACTUAL RESULTS:

  • Verified that all data and cache are cleared when Auto Shred is set to App Close

iPhone 14 / iOS 17.7

1 2 3
1 2 3
1 2 3

iPad Mini (6th gen) / iPadOS 18.0.1

https://github.com/user-attachments/assets/1822cff6-6f5c-4728-a733-2d61ab18bbea

hffvld avatar Oct 24 '24 19:10 hffvld