brave-browser icon indicating copy to clipboard operation
brave-browser copied to clipboard

Orange focus ring in `Enter a sync code` dialog

Open stephendonner opened this issue 1 year ago • 2 comments

Description

Orange focus ring in Enter a sync code dialog

Steps to reproduce

  1. install 1.69.62
  2. launch Brave
  3. open brave://sync
  4. click on Start using sync
  5. click I have a sync code

Actual result

Screen Shot 2024-06-28 at 12 04 15 PM

Expected result

Blurple?-colored focus ring?

Reproduces how often

Easily reproduced

Brave version (brave://version info)

Brave | 1.69.62 Chromium: 127.0.6533.17 (Official Build) nightly (x86_64)
-- | --
Revision | 50af8e07a47dfe29f581936e45c07e8ee8b676f5
OS | macOS Version 11.7.10 (Build 20G1427)

Channel information

  • [X] release (stable)
  • [X] beta
  • [X] nightly

Reproducibility

  • [X] with Brave Shields disabled
  • [X] with Brave Rewards disabled
  • [ ] in the latest version of Chrome

Miscellaneous information

cc @aguscruiz @rebron @brave/qa-team @fallaciousreasoning

stephendonner avatar Jun 28 '24 19:06 stephendonner

Also linux

Screen Shot 2024-06-28 at 12 44 31 PM

stephendonner avatar Jun 28 '24 19:06 stephendonner

Can i work over this issue?

kmr-ankitt avatar Jun 30 '24 14:06 kmr-ankitt

Can i work over this issue?

Sure; submit a Pull Request fixing it, and we'll assign to you! Thanks!

stephendonner avatar Jun 30 '24 21:06 stephendonner

can i work on this issue

nkumawat34 avatar Aug 18 '24 05:08 nkumawat34

Verified with

Brave | 1.71.101 Chromium: 129.0.6668.70 (Official Build) beta (x86_64)
-- | --
Revision | 734075a5959db3e93d6def81a15e1fc6c2609fc2
OS | macOS Version 14.7 (Build 23H124)

Reproduced orange focus ring using 1.70.119. Confirmed 1.71.101 has blurple(ish) focus ring for both light and dark themes.

1.70.119 1.71.101
1 70 119 dk 1 71 dk
1 70 lt 1 71 lt

Verified with

Brave | 1.71.101 Chromium: 129.0.6668.70 (Official Build) beta (arm64)
-- | --
Revision | 734075a5959db3e93d6def81a15e1fc6c2609fc2
OS | macOS Version 15.0 (Build 24A335)

Reproduced orange focus ring using 1.70.119. Confirmed 1.71.101 has blurple(ish) focus ring for both light and dark themes.

1.70.119 1.71.101
1 70 dk 1 71 dk
1 70 lt 1 71 lt

LaurenWags avatar Sep 30 '24 15:09 LaurenWags

Verification PASSED using

Brave | 1.71.110 Chromium: 129.0.6668.100 (Official Build) beta (64-bit)
-- | --
Revision | 46cd0b1af7127687895fcaceff93dd80e29e6f2b
OS | Windows 11 Version 23H2 (Build 22631.4317)

Can reproduce Orange focus ring in 1.70.126 only in light mode. Dark mode has white.

light dark
Image Image

Confirmed Orange focus ring is no longer shown in Enter a sync code dialog in light mode and it shows blurple(ish) and dark mode didnt' change.

light dark
Image Image

MadhaviSeelam avatar Oct 09 '24 20:10 MadhaviSeelam

Verified with

Brave | 1.71.112 Chromium: 130.0.6723.44 (Official Build) (64-bit)
-- | --
Revision | 7d51df656b247f9432ee714a6d160142a1e11c13
OS | Linux

Reproduced orange focus ring using 1.70.126 with light theme. Confirmed 1.71.112 no longer has orange focus ring.

1.70.126 1.71.112
Image Image
Image Image

LaurenWags avatar Oct 14 '24 18:10 LaurenWags