brave-browser icon indicating copy to clipboard operation
brave-browser copied to clipboard

tapping `Switch to the free model` doesn't do anything (need to tap `Retry`)

Open kjozwiak opened this issue 1 year ago • 1 comments

Description

Tapping on Switch to the free model doesn't do anything. Once you tap on Switch to the free model, you'll instantly see a Retry button appear in it's place. Tapping on the Retry button correctly switches the user to LLama 2 13b as expected.

Steps to reproduce

Note: This assumes that you've already gone through onboarding and have hit the rate limit

  1. once you've reached a rate limit on either Mixtral or Calude Instant, ensure that the upsell UI is visible
  2. tap on Switch to the free model and notice that it will be replayed with a Retry button (nothing happens the first time around)
  3. tap on Retry and you'll know be switched to LLama 2 13b

Actual result

https://github.com/brave/brave-browser/assets/2602313/a9117651-f133-4c20-8aba-8924f87a45c1

Expected result

Tapping on Switch to the free model should switch the user to LLama 2 13b without the need to tap on Retry (unless it failed).

Issue reproduces how often

Version/Channel Information:

  • Can you reproduce this issue with the current Play Store version? N/A (reproducible with the 1.63.x RC)
  • Can you reproduce this issue with the current Play Store Beta version? Yes
  • Can you reproduce this issue with the current Play Store Nightly version? Yes

Device details

  • Install type (ARM, x86): ARM
  • Device type (Phone, Tablet, Phablet): Pixel 6
  • Android version: Android 14

Brave version

Brave | 1.63.155 Chromium: 122.0.6261.29 (Official Build) (64-bit)
--- | ---
Revision | b2be2c6f5b7340629f672ce706f5bfd62b113f82
OS | Android 14; Build/AP11.231215.009; 34; REL

Website problems only

  • Does the issue resolve itself when disabling Brave Shields? N/A
  • Does the issue resolve itself when disabling Brave Rewards? N/A
  • Is the issue reproducible on the latest version of Chrome? N/A

Additional information

kjozwiak avatar Feb 16 '24 04:02 kjozwiak

Also reproduces with the same flow, in desktop build:

Brave | 1.63.155 Chromium: 122.0.6261.29 (Official Build) (x86_64)
-- | --
Revision | b2be2c6f5b7340629f672ce706f5bfd62b113f82
OS | macOS Version 14.4 (Build 23E5196e)
example example example example
Screenshot 2024-02-16 at 12 14 05 AM Screenshot 2024-02-16 at 12 14 22 AM Screenshot 2024-02-16 at 12 14 24 AM Screenshot 2024-02-16 at 12 14 33 AM

stephendonner avatar Feb 16 '24 08:02 stephendonner

Verification PASSED using

Brave | 1.65.83 Chromium: 123.0.6312.46 (Official Build) beta (64-bit)
-- | --
Revision | 1ea667c8c59a4a4a327579974ec11149a738e750
OS | Windows 11 Version 23H2 (Build 22631.3296)

Reproduced this issue in 1.64.105 in Win 11 x64

  1. Installed 1.65.83
  2. launched Brave
  3. loaded https://www.cnn.com/2024/03/15/economy/nar-realtor-commissions-settlement/index.html
  4. summarize the page
  5. click I understand
  6. query Leo until Response rate limit reached message is shown
  7. clicked Switch to the free model

Confirmed Leo switched to Llama 2 13b by Meta model

Confirmed Llama model summarized the article as expected

step 6 step 7
image image

MadhaviSeelam avatar Mar 15 '24 23:03 MadhaviSeelam

Verified PASSED using

Brave	1.65.96 Chromium: 123.0.6312.86 (Official Build) beta (x86_64) 
Revision	5d9143e1a0812c53bdc27fd5384591254306a88c
OS	macOS Version 11.7.10 (Build 20G1427)

Steps:

  1. installed 1.65.96
  2. launched Brave
  3. loaded https://www.cnn.com/2024/03/15/economy/nar-realtor-commissions-settlement/index.html
  4. summarize the page
  5. click I understand
  6. query Leo until Response rate limit reached message is shown
  7. clicked Switch to the free model

Confirmed Leo switched to Llama 2 13b by Meta model

Confirmed Llama model summarized the article as expected

example example example example example example
Screen Shot 2024-03-28 at 5 27 51 PM Screen Shot 2024-03-28 at 5 27 57 PM Screen Shot 2024-03-28 at 5 28 01 PM Screen Shot 2024-03-28 at 5 28 16 PM Screen Shot 2024-03-28 at 5 28 21 PM Screen Shot 2024-03-28 at 5 28 54 PM

stephendonner avatar Mar 29 '24 00:03 stephendonner

Verification PASSED using

Brave	1.65.100 Chromium: 123.0.6312.86 (Official Build) beta (64-bit) 
Revision	8456ab291d9c823aaff5de460a63b53485320488
OS	Linux

Steps:

  1. installed 1.65.100
  2. launched Brave
  3. loaded https://www.cnn.com/2024/04/01/health/non-alcoholic-sober-bars-dry-january-wellness-cec/index.html
  4. clicked on Summarize this page
  5. clicked on I understand
  6. waited
  7. clicked on Suggest questions...
  8. clicked on each questions
  9. waited for output
  10. confirmed I hit the rate-limiting dialog
  11. clicked on Switch to the free model

Confirmed Leo switched to Llama 2 13b by Meta model

Confirmed Llama model summarized the article as expected

example example example example example
Screen Shot 2024-04-01 at 1 16 04 PM Screen Shot 2024-04-01 at 1 16 10 PM Screen Shot 2024-04-01 at 1 16 41 PM Screen Shot 2024-04-01 at 1 16 56 PM Screen Shot 2024-04-01 at 1 17 16 PM
example example example example
Screen Shot 2024-04-01 at 1 17 52 PM Screen Shot 2024-04-01 at 1 18 30 PM Screen Shot 2024-04-01 at 1 19 08 PM Screen Shot 2024-04-01 at 1 22 19 PM

stephendonner avatar Apr 01 '24 20:04 stephendonner

Verified on Galaxy Tab S8 and Pixel 7 using version(s):

Device/OS: 
- Galaxy Tab S8 / gts8wifixx-user 14 UP1A.231005.007 release-keys
- Pixel 7 / panther_beta-user 14 AP21.240305.005 release-keys
Brave build: 1.65.101
Chromium: 123.0.6312.86 (Official Build) beta (64-bit) 

STEPS:

  1. Launch Brave
  2. Go to any website, for example, https://chromeunboxed.com
  3. Open Leo > Male sure language model is set to Mixtral or Claude
  4. Send some queries until you reach the rate limit
  5. Tap Switch to the free model > Verify

ACTUAL RESULTS:

  • Verified that tapping Switch to the free model immediately switching to the free Llama 2 13b language model and running the query

Galaxy Tab S8

https://github.com/brave/brave-browser/assets/128532965/0a1abe9f-056a-48f1-9854-02a94874b845

Pixel 7 / Phone

https://github.com/brave/brave-browser/assets/128532965/533ccf7f-898d-409a-b84e-646394c12aaf

hffvld avatar Apr 03 '24 19:04 hffvld