brave-browser icon indicating copy to clipboard operation
brave-browser copied to clipboard

Add iOS metric for primary language

Open DJAndries opened this issue 1 year ago • 5 comments

Please replicate https://github.com/brave/brave-browser/issues/34853.

DJAndries avatar Feb 12 '24 22:02 DJAndries

@iccub I just wanted to check on the status of this. Getting language data on iOS is a high priority for growth as we are monitoring changes in Search and Browser since the European choice screens were released.

AndyAnds265 avatar Apr 02 '24 17:04 AndyAnds265

@DJAndries Hey Darnell. What is the level of effort for this one?

chrismore avatar May 06 '24 17:05 chrismore

We can get it in this week. I do not think we have prioritized it highly

iccub avatar May 06 '24 22:05 iccub

@chrismore Should be a relatively short task

DJAndries avatar May 06 '24 22:05 DJAndries

If it is low effort, we might as well knock it out so we have parity across platforms with the insights.

Is this in the P3A pod or iOS general pod?

chrismore avatar May 07 '24 20:05 chrismore

@chrismore do you have any preference what release version do you want to have this in?

iccub avatar May 13 '24 22:05 iccub

@chrismore do you have any preference what release version do you want to have this in?

Sooner the better :-)

chrismore avatar May 15 '24 00:05 chrismore

Verification PASSED on iPhone 8 version 16.7.8 running Brave Nightly 1.68(79)

  • Verified few languages by comparing the actual langcodes matching with response value and browser language.

English:

langcodes local state device language device region
image IMG_4623 IMG_4624 IMG_4635

Germany:

langcodes local state device language device region
image IMG_4625 IMG_4632 IMG_4633

France:

langcodes local state device language device region
image IMG_4628 IMG_4626 IMG_4627

Kannada:

langcodes local state device language device region
image IMG_4631 IMG_4629 IMG_4630

GeetaSarvadnya avatar Jun 24 '24 16:06 GeetaSarvadnya