brave-browser icon indicating copy to clipboard operation
brave-browser copied to clipboard

Sync chain randomly ceases working

Open valynor opened this issue 1 year ago • 65 comments

Since 1.61 across all kinds of devices (Windows, Android, macOS, iOS, iPadOS) the Sync chain randomly fails and is not updating across devices anymore.

More information from multiple users here:

https://community.brave.com/t/sync-stops-working-randomly-and-cannot-be-restarted-without-new-sync-chain-bookmarks-no-longer-syncing-send-to-device-no-longer-working-reliably-either/521949

This is a major issue IMHO, reliable syncing is very important for a lot of users. Please assign a high priority to this bug.

valynor avatar Dec 26 '23 23:12 valynor

I'm struggling with the same problem. Last time when it happened I've created a new sync ring, but it helped only for a few days because now I've realized it randomly stopped again. Almost all models show "Backed off message" at brave://sync-internals. Status from Last Completed Session: Commit Step Result | Protocol error (TRANSIENT_ERROR)

the-overdriven avatar Jan 24 '24 21:01 the-overdriven

My devices are also not syncing.

I get a similar message at brave://sync-internals/.

Status from Last Completed Session
Sync Source	GU_TRIGGER
GetKey Step Failed	false
Download Step Result	Success
Commit Step Result	Protocol error (TRANSIENT_ERROR)

hamirmahal avatar Jan 24 '24 21:01 hamirmahal

Same here. No sync between pc and android. (TRANSIENT_ERROR)” shows in sync internals.

Repeat the synchronization process fixes the problem (even if only temporarily), doesn't it?"

Jorg333 avatar Jan 25 '24 10:01 Jorg333

+1. Same issue here, and didn't realize it immediately because I don't change my bookmarks (and also look immediately to verify that change on all of my other devices) very often. I imagine many, many others are in a similar situation.

ntarox avatar Jan 27 '24 01:01 ntarox

It has been exactly 30 days since my post and the new sync chain I made back then broke again today with

Commit Step Result | Protocol error (TRANSIENT_ERROR)

Took me 15-20 minutes to create a new one on my 5 devices and to verify everything works correctly. This is really annoying and a major issue for people who rely on it to work.

valynor avatar Jan 27 '24 17:01 valynor

Sync stopped working for me somewhere around 2023.12.17 (+- couple days) and is non-functional ever since (2 windows and 1 android device). Really annoying. Sending a tab/link from the URL bar to another device also doesn't work.

Tallyrald avatar Jan 29 '24 10:01 Tallyrald

I've been facing the same issue. In recent months, there was a delay, but it usually synced up after a few hours. However, for the past few weeks, there's been no synchronization between my devices at all.

In the past, a solution to this problem was leaving and rejoining the chain. Unfortunately, this time, that didn't resolve the issue.

Currently, Brave is synced across all my devices, including:

  • 2 Windows PCs (Win10 and Win11)
  • 2 Apple MacBooks
  • 1 Linux system
  • 1 iOS (iPhone).

Interestingly, my friends using Brave haven't experienced this problem, but they only have around two devices and fewer than 100 bookmarks.

I acknowledge that my bookmark collection is extensive. I'm reluctant to switch browsers because I genuinely love Brave, but seamless syncing is a crucial feature for me.

For further analysis, I've attached a screenshot of the Brave sync internals. Maybe this could be a help to someone.

Screenshot 2024-01-30 at 14 01 27

dennzo avatar Jan 30 '24 13:01 dennzo

I have the same issue. Under brave://sync-internals/ I see this:

Throttled or Backoff | true

If I click on any Commit Response in the Sync Protocol Log I see a bunch of errors like this:

{
    "error_message": "There are already 50000 non-deleted objects in store",
    "response_type": "OVER_QUOTA"
}

Despite of this, the Commit Response says: Result: Success and in the response there is also this: "error_code": "SUCCESS".

It seems history is also synced and it pushes the objects to sync easily over the quota.

EDIT: https://community.brave.com/t/bookmark-sync-isnt-working-over-quota/525475/2

Alexey Barabash: Starting from 1.61 version there was a change so all history visits are synced now; before only visits from url bar were synced. We are working on fix.

jonatan-ivanov avatar Jan 31 '24 22:01 jonatan-ivanov

Connected to https://github.com/brave/brave-browser/issues/35042#issuecomment-1920066849, if I create a new chain, it works since the object store is empty again. But I think if you do not disable history sync, it will be full again relatively quickly.

I guess removing history from the remote object store and disabling history sync could also work but I have no idea how to do the former.

I think this also means that 1.61 writes full everyone's object store who use the browser eventually and makes the sync feature broken for them.

jonatan-ivanov avatar Jan 31 '24 22:01 jonatan-ivanov

@AlexeyBarabash I'm not familiar with Brave's triaging process but if the above is correct, breaking sync for everyone who actually uses the browser could get higher priority in my opinion.

jonatan-ivanov avatar Jan 31 '24 22:01 jonatan-ivanov

The problem has fixed itself! I just realized that I have all three devices (2 PCs and a mobile) syncing again, with all the bookmarks in their place.

Thx Brave ;)

Jorg333 avatar Feb 02 '24 11:02 Jorg333

The problem has fixed itself! I just realized that I have all three devices (2 PCs and a mobile) syncing again, with all the bookmarks in their place.

For me, there is still "Protocol error (TRANSIENT_ERROR)".

oleg-derevenetz avatar Feb 02 '24 11:02 oleg-derevenetz

Having this issue right now, added my Linux machine to my sync chain, and only bookmarks were synced. None of my extensions or autofill were synced even though I left the browser open for an hour, had Sync Everything selected. Uninstalled, reinstalled, removed from sync chain, re-added to sync chain, seems to be stuck on "In progress..." in the Sync Node Browser Tab. Clicking Request Start or Trigger Updates does nothing.

p134c0d3 avatar Feb 05 '24 05:02 p134c0d3

Same situation here syncing with 2 Windows 11 computers and 2 Android devices. The only thing that works is deleting the sync chain completely and recreating it.

kmfoodservice avatar Feb 05 '24 08:02 kmfoodservice

Only fix I've found so far is leaving the browser open overnight, so I'm think the sync might just be EXTREMELY delayed...

In the morning, when I checked it out, all autofill and extensions were finally synced.

p134c0d3 avatar Feb 08 '24 21:02 p134c0d3

Again "Protocol error (TRANSIENT_ERROR)"

Jorg333 avatar Feb 17 '24 09:02 Jorg333

same for me

martinlanger90 avatar Feb 17 '24 17:02 martinlanger90

Same error for me "There are already 75000 non-deleted objects in store".

image

it would also give me a http error under "Download Step Result".

For me, turning off "sync everything" and only turning on everything except for history got everything seeming to sync again somewhat, however, I would love to be able to sync history... It also is still inconsistent and hits that limit nonetheless, but did allow it to sync some things on a new browser at least (such as extensions, etc that weren't before)

BenjaminMichaelis avatar Mar 06 '24 05:03 BenjaminMichaelis

That worked only for one time sync... now again transient error....

martinlanger90 avatar Mar 06 '24 07:03 martinlanger90

That worked only for one time sync... now again transient error....

Yeah, 12 hours later and it stopped again... bummer

BenjaminMichaelis avatar Mar 06 '24 15:03 BenjaminMichaelis

Same issue here, this has been an issue for a while, at least 6+ months. The only working solution so far has been to completely remove and create a new sync chain, but the new chain always stops working after a month or two.

Edit: I sync between three Debian machines and two Android phones. I sync everything on all devices.

petcap avatar Mar 11 '24 13:03 petcap

@AlexeyBarabash Plz help

mogarchy avatar Mar 12 '24 05:03 mogarchy

Fyi: if history sync is on no matter what you do this issue will come back (unless this will be fixed in Brave), see: https://github.com/brave/brave-browser/issues/35042#issuecomment-1920066849

As a workaround, you need to disable syncing history and remove objects from your object store. The only way I'm aware to remove objects from your object store is creating a new sync chain (history sync disabled).

jonatan-ivanov avatar Mar 12 '24 23:03 jonatan-ivanov

Fyi: if history sync is on no matter what you do this issue will come back (unless this will be fixed in Brave), see: #35042 (comment)

As a workaround, you need to disable syncing history and remove objects from your object store. The only way I'm aware to remove objects from your object store is creating a new sync chain (history sync disabled).

Yes this is the only method that works and you can see it works immediately Also fixes the "recent tabs" sync some users are not getting, you may want to merge issues

LorenzoVonMatterhom avatar Mar 14 '24 10:03 LorenzoVonMatterhom

Surprised that this has been an issue for 4+ months for a browser as mature as Brave. @AlexeyBarabash, can we get a brief explanation on why this is such low priority? The sync feature is quite literally broken

ntarox avatar Mar 14 '24 19:03 ntarox

+1. I won't bother bookmarking this page, since it won't sync to other browsers in my chain. :/

Geologic9222 avatar Mar 19 '24 17:03 Geologic9222

I think the issue seems to be related to issue as discussed at https://community.brave.com/t/sync-stops-working-randomly-and-cannot-be-restarted-without-new-sync-chain-bookmarks-no-longer-syncing-send-to-device-no-longer-working-reliably-either/521949/58 which is essentially the full history on Sync caused it to surpass commits.

It has been expanded on with https://github.com/brave/go-sync/pull/218/files where I guess he increased objects limits to 85k and decreased history entry expiration interval to 14 days. I have actually seen the issue resolve for my devices recently after these adjustments.

I'm not sure if the changes will be suffice. We may need to do as mentioned prior, which is not sync History. But that seems to be the issue and where we stand at the moment.

I'd be curious to see if anyone else who had been experiencing issues have seen it resolve in the past week or so.

Saoiray avatar Mar 27 '24 20:03 Saoiray

This is clearly not a priority for the team or org, and it's eroding trust in the platform on my end. Odd as it's billed as one of the premier features that sets Brave apart.

shellscape avatar Mar 30 '24 17:03 shellscape

For the last couple of days, sync started working again and everything was fine... until today. The Transient_error is back and the whole chain stopped once more. In sync-internals the highest number I see in the Type Info table is 778 (bookmarks). History is showing 30 so I'm guessing this isn't just simply an object limit.

Tallyrald avatar Mar 31 '24 09:03 Tallyrald

Also been having this issue. Noticed it a few weeks ago when a bookmark didn't go through to my other computer. Everything is marked Backed off and I have the error of "Commit Step Result Protocol error (TRANSIENT_ERROR)"

calipupsr avatar Apr 10 '24 06:04 calipupsr