brave-browser
brave-browser copied to clipboard
Google doesn't show in autofill area when set as the phone's Autofill Service
Description
On Android phones, users can go to Settings
> Autofill service
and set Google as the default provider
They need to click the gear icon to pick which Google account and to enter the client side passphrase
Then, when on a webpage in Chrome - you can click the username or password field on forms and it'll let you pick which account / which saved password
Steps to reproduce
- Go to settings
- Search for
Autofill service
- Pick the option
- Select Google as the default option (if it isn't already)
- You should already have a Google account. Pick Google as the service
- If you had 1Password installed, you may need to go to
Settings
>Accessibility
>1Password
and turn off global registration. That seems to override everything - Visit a few sites in Chrome; add passwords
- Go into Brave on those same sites
- Click username or pw field
Actual result
Nothing shows in the context area that would usually show autofill items. The numbers show there since there are no registered provider
Expected result
It should work like Chrome
Issue reproduces how often
100%
Version/Channel Information:
Release channel, 1.46
It's not clear why this isn't showing. We may need the android.permission.BIND_AUTOFILL_SERVICE
permission for this to work
See https://github.com/brave/brave-browser/issues/24618 (which was created to have Brave show as an autofill service)
The only other change I can think of is that we had given up the QUERY_ALL_PACKAGES
permission recently. Not sure if that is needed to detect autofill services?
@bsclifton QUERY_ALL_PACKAGES
is used only to get all the applications on the device. so i don't think that could be the reason.
I'm experiencing this issue with Android 13 and Bitwarden set as autofill provider.
This was recently added to Vanadium.
+1 on Twitter: https://twitter.com/anil_makadia/status/1632368123792990211
+1
I think this came to me via another user, who DMed.
@BrendanEich we looked into the issue in the past. basically, Google autofill service is not working with other chromium based browsers (edge, opera, vivaldi). They have included autofill service in the google search app: https://play.google.com/store/apps/details?id=com.google.android.googlequicksearchbox not in chromium. we need to add autofill service implementation on Brave app separately. security review: https://github.com/brave/reviews/issues/1053 for more context.
Is this still a known issue? I'm experiencing this with both Beta and Release versions of Brave for both Bitwarden and Proton Pass after setting each as my Auto-Fill service. Seems to work in my other browser, Vanadium.