brave-browser icon indicating copy to clipboard operation
brave-browser copied to clipboard

[ads] Reset brave://rewards estimated earnings at midnight local time

Open Miyayes opened this issue 2 years ago • 1 comments

Description

On the 1st of the month, estimated earnings resets to 0.0. However, the countdown payout banner (which says "Your x earnings will arrive in n days") sometimes does not appear immediately (depending on local time vs UTC time?), causing confusion.

Solution

The instant estimated earnings resets to 0.0, the countdown payout banner should appear.

Miyayes avatar Oct 01 '22 01:10 Miyayes

@tmancey Was there anything here you needed to share with Zenparsing to get this ready to implement?

Miyayes avatar Apr 15 '23 10:04 Miyayes

@Miyayes payment tokens stored on the server are in UTC. Implementing this change will result in a disparity between client-side and server-side earnings. What are your thoughts on this? cc @iambrianfung

tmancey avatar May 04 '24 17:05 tmancey

@btlechowski we believe this was fixed by another issue. Thanks

tmancey avatar Jun 06 '24 21:06 tmancey

@btlechowski I could not reproduce so would be great if QA could test too. Thanks

tmancey avatar Jul 25 '24 17:07 tmancey