brave-browser icon indicating copy to clipboard operation
brave-browser copied to clipboard

Published 20 hours ago • verified publisher icon brave

Speedreader theme support doesn't work on Linux

Open stephendonner opened this issue 2 years ago • 2 comments

Description

Speedreader theme support doesn't work on Linux.

Spinning this off from https://github.com/brave/brave-browser/issues/23447 because it was verified there on Windows 10-x64 and macOS-x64.

Steps to Reproduce

  1. installed 1.44.95
  2. launched Brave
  3. deleted the jicbkmdloagakknpihibphagfckhjdih component directory
  4. confirmed brave://settings/appearance is Light
  5. loaded https://www.bbc.com/news/business-58559179
  6. clicked on the Speedreader icon
  7. opened Developer Tools -> Console panel
  8. entered document.documentElement.setAttribute('data-theme', 'dark') and pressed return
  9. entered document.documentElement.setAttribute('data-theme', 'sepia') and pressed return

Actual result:

Nothing (visually) happens, but the data-theme attribute seems to get correctly set

Screen Shot 2022-09-21 at 10 31 56 AM

Expected result:

Should change the theme/mode to dark, sepia, etc.

Reproduces how often:

100%

Brave version (brave://version info)

Brave 1.44.95 Chromium: 106.0.5249.40 (Official Build) (64-bit)
Revision fab1d91915d2722d6339aaa7f4e9ce44f1e9b103-refs/branch-heads/5249@{#442}
OS Linux

Version/Channel Information:

  • Can you reproduce this issue with the current release?
  • Can you reproduce this issue with the beta channel?
  • Can you reproduce this issue with the nightly channel?

Other Additional Information:

  • Does the issue resolve itself when disabling Brave Shields?
  • Does the issue resolve itself when disabling Brave Rewards?
  • Is the issue reproducible on the latest version of Chrome?

Miscellaneous Information:

cc @boocmp @rebron

stephendonner avatar Sep 21 '22 17:09 stephendonner

FWIW, I couldn't reproduce this on Version 1.45.64 Chromium: 106.0.5249.40 (Official Build) nightly (64-bit). Setting data-theme=light, data-theme=dark & data-theme=sepia all worked in Nightly.

I tested with a light base theme and a dark base theme, both seemed to work (I'm on Ubuntu 22.04.1 LTS)

fallaciousreasoning avatar Sep 21 '22 20:09 fallaciousreasoning

Repro'd in 1.44.93 Chromium: 105.0.5195.136 (Official Build) beta (64-bit) (a semi recent Beta) - does something need an uplift?

fallaciousreasoning avatar Sep 21 '22 20:09 fallaciousreasoning

Actually we do not need this functional as javascript function, It's only needed in Speedreader bubble v2 (https://github.com/brave/brave-core/pull/14151) which merged in 45. I think we should test new bubble instead of API itself. Anyway could you please attach the html source of the speedreaded page? I want to check what css really loaded.

boocmp avatar Sep 22 '22 04:09 boocmp