brave-browser icon indicating copy to clipboard operation
brave-browser copied to clipboard

Left line hint is not displayed next to the icon in active state in brave://settings sidebar

Open MadhaviSeelam opened this issue 2 years ago • 2 comments

Description

Steps to Reproduce

  1. Install 1.44.86
  2. launch Brave
  3. open brave://settings
  4. click on Appearance in the sidebar

Actual result:

Left line hint is not displayed next to the icon in the active state image

Expected result:

Left line should be displayed for the Appearance icon in the active state

Screenshot 2022-09-15 at 12 44 09 PM

Reproduces how often:

100%

Brave version (brave://version info)

Brave 1.44.86 Chromium: 105.0.5195.127 (Official Build) beta (64-bit)
Revision 912488396852bf658ab32465980c0b93a3c27a83-refs/branch-heads/5195@{#1109}
OS Windows 11 Version 21H2 (Build 22000.978)

Version/Channel Information:

  • Can you reproduce this issue with the current release? No
  • Can you reproduce this issue with the beta channel? Yes
  • Can you reproduce this issue with the nightly channel? N/A

Other Additional Information:

  • Does the issue resolve itself when disabling Brave Shields?
  • Does the issue resolve itself when disabling Brave Rewards?
  • Is the issue reproducible on the latest version of Chrome?

Miscellaneous Information:

@fallaciousreasoning @aguscruiz @rebron cc: @stephendonner

MadhaviSeelam avatar Sep 15 '22 18:09 MadhaviSeelam

I would like to contribute to this issue.

wolbek avatar Sep 17 '22 16:09 wolbek

Go for it @wolbek! This file brave/browser/resources/settings/brave_overrides/settings_menu.js is probably a good starting point :smile:

fallaciousreasoning avatar Sep 19 '22 21:09 fallaciousreasoning

If this issue is still open , may I work on this I am new to open source and this will be my good first issue

prasoonmhwr avatar Sep 22 '22 06:09 prasoonmhwr

Go for it @wolbek! This file brave/browser/resources/settings/brave_overrides/settings_menu.js is probably a good starting point 😄

@fallaciousreasoning Is this the correct path? not able to find it

prasoonmhwr avatar Sep 22 '22 06:09 prasoonmhwr

@prasoonmhwr check it here

https://github.com/brave/brave-core/blob/master/browser/resources/settings/brave_overrides/settings_menu.js

sonithch avatar Sep 22 '22 08:09 sonithch

Yeah go for it!

The spec for the line from our designers is:

width: 4px;
height: 32px;

background: linear-gradient(96.98deg, #E51D00 0%, #E5007B 78.13%);
border-radius: 0px 2px 2px 0px;

fallaciousreasoning avatar Sep 22 '22 22:09 fallaciousreasoning

@fallaciousreasoning I have created the pull request , whom should i assign for review?

prasoonmhwr avatar Sep 23 '22 07:09 prasoonmhwr

Go for it @wolbek! This file brave/browser/resources/settings/brave_overrides/settings_menu.js is probably a good starting point 😄

@fallaciousreasoning Thank you. I have made a pull request according to the specs given.

wolbek avatar Sep 23 '22 15:09 wolbek

I'm really sorry guys, I just realised there are two of you looking at this. @prasoonmhwr I'm going to look at @wolbek's PR, just because he asked if he could work on the issue first.

Really sorry about that everyone.

fallaciousreasoning avatar Sep 26 '22 20:09 fallaciousreasoning

Verification PASSED on

Brave | 1.46.80 Chromium: 107.0.5304.68 (Official Build) beta (64-bit)
-- | --
Revision | a4e93e89d3b3df1be22214603fba846ad0183ca5-refs/branch-heads/5304@{#991}
OS | Windows 10 Version 21H2 (Build 19044.2130)

Ensured that hint is displayed next to each icon setings in brave://settings page

Example Example Example Example Example
image image image image image

GeetaSarvadnya avatar Oct 26 '22 08:10 GeetaSarvadnya