brave-browser icon indicating copy to clipboard operation
brave-browser copied to clipboard

[Android] Add "Are you sure[...]" modal to confirm closing all tabs

Open Brave-Matt opened this issue 3 years ago • 5 comments
trafficstars

Description

The close all tabs on Android browser option can have significant impact on UX if it is selected accidentally. As noted in the internal conversation, the Undo button appears to become unresponsive when the browser attempts to close a significant number of tabs. The modal would help prevent these types of unintended actions. image

cc @deeppandya @timchilds

Additional information

This very situation has happened to at least one user on Community who reached out via DM.

Brave-Matt avatar Sep 06 '22 22:09 Brave-Matt

@rmcfadden3 quick one here - could you please suggest copy for the modal? Something like:

Are you sure you want to close all tabs?

timchilds avatar Sep 06 '22 22:09 timchilds

@timchilds — not sure how much space we'll have in terms of character count, and I'm also not sure the exact behavior here if you have multiple tabs in multiple windows. But anyways here are a couple options:

  • Are you sure you want to close all tabs in Brave?
  • Are you sure you want to close all tabs in this Brave window?
  • Are you sure you want to close all tabs and windows in Brave?

rmcfadden3 avatar Sep 07 '22 16:09 rmcfadden3

Thanks @rmcfadden3. The behavior is it closes all tabs regardless of groups etc. First option makes the most sense to me. That said, @Brave-Matt there does actually appear to be an existing confirmation message. Are users reporting they don't see this message?

image

Either way, it still makes sense to update the copy as the existing copy mentions "Chrome" and a "Recent tabs" feature that does not exist in Brave.

Close all tabs? Are you sure you want to close all tabs in Brave?

cc @deeppandya

timchilds avatar Sep 07 '22 17:09 timchilds

I was not aware that this modal appeared when you selected to close all tabs. The users I've spoken to about this have not mentioned it so maybe they're not seeing it? Let me reach out and find out.

Brave-Matt avatar Sep 08 '22 15:09 Brave-Matt

@Brave-Matt Any update up on this?

@timchilds We do have Recent Tabs feature. So we can still direct users to that. It is accessed in the menus on NTP or a Website.

Sam-Sibley avatar Sep 21 '22 03:09 Sam-Sibley