brave-browser
brave-browser copied to clipboard
Update verified creator criteria
Description
https://github.com/brave/internal/issues/898
Split it into small PR and then medium sized PR (where we remove dead branches). Do small PR first — can defer medium PR.
Added android label as per the discussion
Uplift to 1.45.x: https://github.com/brave/brave-core/pull/15176
The above requires 1.45.87
or higher for 1.45.x
verification 👍
Verification PASSED on
Brave | 1.45.87 Chromium: 106.0.5249.91 (Official Build) beta (64-bit)
-- | --
Revision | fa96d5f07b1177d1bf5009f647a5b8c629762157-refs/branch-heads/5249@{#707}
OS | Windows 10 Version 21H2 (Build 19044.2006)
- Verified the test plan from https://github.com/brave/brave-core/pull/15167
Clean Profile Checks - PASSED
- Confirmed that the "connected" publisher appears "not verified" (no blue checkmark on the Rewards icon)
- Confirmed that in the Rewards panel, the status is displayed as "Unverified Creator" and appropriate hover text is shown
- Confirmed that in the tipping banner, the "creator is not signed up yet" message is displayed
- Confirmed no "verified" checkmark displays on the tipping banner
- Confirmed that when tipping this "connected" creator, using vBAT, a pending tip is created
Example | Example | Example | Example | Example |
---|---|---|---|---|
![]() |
![]() |
![]() |
![]() |
![]() |
Also confirmed that if a connected creator is listed in the Auto Contribution list, it does not get any AC BAT:
Example | Example |
---|---|
![]() |
![]() |
Upgrade Profile Checks - PASSED
- Install release version (1.44.x) w/ staging env and reconcile interval
- Close and relaunch (pull griffin seed)
- Enable Rewards, claim UGP grant
- Populate AC list with a mix of creators, including at least one "connected" creator
- Do a one time tip for a "connected" creator
- Set up a monthly tip for "connected" creator
- Close Brave
- Rename profile to Beta (1.45.87)
- Launch with beta version which contains this fix
- Look at brave://rewards page --> "connected" creator are NOT displayed with the verified checkmark as expected
- Wait for reconcile interval to occur so AC & monthly tips are contributed
- AC and monthly tips are completed only for the verified creators
- Confirmed that monthly tips for the connected creators are NOT processed instead goes to the pending contribution table
Step 4 | Step 5 | Step 6 | Step 10 | Step 12 | Step 12 | Step 12 | Step 12 | Step 12 |
---|---|---|---|---|---|---|---|---|
![]() |
![]() |
![]() |
![]() |
![]() |
![]() |
![]() |
![]() |
![]() |
Verified on Google Pixel 3 XL with Android 12 running 1.45.100
Verified test plan from https://github.com/brave/brave-core/pull/15167#issue-1381490244
Clean Profile Checks - PASSED
- Confirmed that the "connected" publisher appears "not verified" (no blue checkmark on the Rewards icon)
- Confirmed that in the tipping banner, the "creator is not signed up yet" message is displayed
- Confirmed no "verified" checkmark displays on the tipping banner
- Confirmed that when tipping this "connected" creator, using vBAT, a pending tip is created
Example | Example | Example |
---|---|---|
![]() |
![]() |
![]() |
Also confirmed that if a connected creator is listed in the Auto Contribution list, it does not get any AC BAT:
Example | Example |
---|---|
![]() |
![]() |
Upgrade Profile Checks - PASSED
- Install beta version of 1.44.x, use QA Prefs to set staging env and verbose logging. (I used 1.44.93)
- Close and relaunch as necessary.
- Enable Rewards, claim UGP grant
- Populate AC list with a mix of creators, including at least one "connected" creator
- Do a one time tip for a "connected" creator
- Set up a monthly tip for "connected" creator
- Close Brave
- Update to 1.45.x Beta for Rewards
- Launch
- Look at brave://rewards page --> "connected" creator no longer displays the verified checkmark in all places (AC, tips, monthly tips, statement, etc)
- Close and advance system date to reconcile date so AC & monthly tips are contributed
- AC and monthly tips are completed --> "connected" creator does not get the AC and monthly tip set up prior to upgrade --> the monthly tip was added to the "Pending contributions" list --> AC was only completed for fully KYC'd creators
Step 4 | Step 5 | Step 6 | Step 10 | Step 10 | Step 12 | Step 12 | Step 12 |
---|---|---|---|---|---|---|---|
![]() |
![]() |
![]() |
![]() |
![]() |
![]() |
![]() |
![]() |