brave-browser icon indicating copy to clipboard operation
brave-browser copied to clipboard

Update verified creator criteria

Open Miyayes opened this issue 2 years ago • 1 comments

Description

https://github.com/brave/internal/issues/898

Miyayes avatar Aug 30 '22 19:08 Miyayes

Split it into small PR and then medium sized PR (where we remove dead branches). Do small PR first — can defer medium PR.

Miyayes avatar Aug 31 '22 16:08 Miyayes

Added android label as per the discussion

deeppandya avatar Sep 28 '22 19:09 deeppandya

Uplift to 1.45.x: https://github.com/brave/brave-core/pull/15176

Miyayes avatar Oct 04 '22 18:10 Miyayes

The above requires 1.45.87 or higher for 1.45.x verification 👍

kjozwiak avatar Oct 04 '22 19:10 kjozwiak

Verification PASSED on


Brave | 1.45.87 Chromium: 106.0.5249.91 (Official Build) beta (64-bit)
-- | --
Revision | fa96d5f07b1177d1bf5009f647a5b8c629762157-refs/branch-heads/5249@{#707}
OS | Windows 10 Version 21H2 (Build 19044.2006)

  • Verified the test plan from https://github.com/brave/brave-core/pull/15167
Clean Profile Checks - PASSED
  • Confirmed that the "connected" publisher appears "not verified" (no blue checkmark on the Rewards icon)
  • Confirmed that in the Rewards panel, the status is displayed as "Unverified Creator" and appropriate hover text is shown
  • Confirmed that in the tipping banner, the "creator is not signed up yet" message is displayed
  • Confirmed no "verified" checkmark displays on the tipping banner
  • Confirmed that when tipping this "connected" creator, using vBAT, a pending tip is created
Example Example Example Example Example
image image image image image

Also confirmed that if a connected creator is listed in the Auto Contribution list, it does not get any AC BAT:

Example Example
image image
Upgrade Profile Checks - PASSED
  1. Install release version (1.44.x) w/ staging env and reconcile interval
  2. Close and relaunch (pull griffin seed)
  3. Enable Rewards, claim UGP grant
  4. Populate AC list with a mix of creators, including at least one "connected" creator
  5. Do a one time tip for a "connected" creator
  6. Set up a monthly tip for "connected" creator
  7. Close Brave
  8. Rename profile to Beta (1.45.87)
  9. Launch with beta version which contains this fix
  10. Look at brave://rewards page --> "connected" creator are NOT displayed with the verified checkmark as expected
  11. Wait for reconcile interval to occur so AC & monthly tips are contributed
  12. AC and monthly tips are completed only for the verified creators
  13. Confirmed that monthly tips for the connected creators are NOT processed instead goes to the pending contribution table
Step 4 Step 5 Step 6 Step 10 Step 12 Step 12 Step 12 Step 12 Step 12
image image image image image image image image image

GeetaSarvadnya avatar Oct 06 '22 04:10 GeetaSarvadnya

Verified on Google Pixel 3 XL with Android 12 running 1.45.100

Verified test plan from https://github.com/brave/brave-core/pull/15167#issue-1381490244

Clean Profile Checks - PASSED
  • Confirmed that the "connected" publisher appears "not verified" (no blue checkmark on the Rewards icon)
  • Confirmed that in the tipping banner, the "creator is not signed up yet" message is displayed
  • Confirmed no "verified" checkmark displays on the tipping banner
  • Confirmed that when tipping this "connected" creator, using vBAT, a pending tip is created
Example Example Example
Screenshot_20221014-094804 Screenshot_20221014-094830 Screenshot_20221014-094917

Also confirmed that if a connected creator is listed in the Auto Contribution list, it does not get any AC BAT:

Example Example
Screenshot_20221014-095421 Screenshot_20221114-095556
Upgrade Profile Checks - PASSED
  1. Install beta version of 1.44.x, use QA Prefs to set staging env and verbose logging. (I used 1.44.93)
  2. Close and relaunch as necessary.
  3. Enable Rewards, claim UGP grant
  4. Populate AC list with a mix of creators, including at least one "connected" creator
  5. Do a one time tip for a "connected" creator
  6. Set up a monthly tip for "connected" creator
  7. Close Brave
  8. Update to 1.45.x Beta for Rewards
  9. Launch
  10. Look at brave://rewards page --> "connected" creator no longer displays the verified checkmark in all places (AC, tips, monthly tips, statement, etc)
  11. Close and advance system date to reconcile date so AC & monthly tips are contributed
  12. AC and monthly tips are completed --> "connected" creator does not get the AC and monthly tip set up prior to upgrade --> the monthly tip was added to the "Pending contributions" list --> AC was only completed for fully KYC'd creators
Step 4 Step 5 Step 6 Step 10 Step 10 Step 12 Step 12 Step 12
Screenshot_20221014-105858 Screenshot_20221014-105906 Screenshot_20221014-105914 Screenshot_20221014-110205 Screenshot_20221014-110347 Screenshot_20221114-111028 Screenshot_20221114-111042 Screenshot_20221114-111106

LaurenWags avatar Oct 14 '22 13:10 LaurenWags