Rename NTPCustomBackgroundImageService => BraveNTPCustomBackgroundService

[sangwoo108]

It's dealing with not only images but also colors.

[akshat-rawat]

Hey, can I work on this one? I got everything setup just have a couple of questions before starting.

[sangwoo108]

Hi @akshat-rawat ! I really appreciate your interest. It's still valid but unfortunately, there's already a class named NTPCustomBackgroundService from upstream. So we need to come up with a better name.

cc. @simonhong

[debanjana-a11y]

It's still valid but unfortunately, there's already a class named NTPCustomBackgroundService from upstream. So we need to come up with a better name.

has the new name been finalized ?

[sangwoo108]

Not yet, but I think BraveNTPCustomBackgroundService might be good. @simonhong What do you think about this?

[simonhong]

BraveNTPCustomBackgroundService looks good 👍🏼

[debanjana-a11y]

I was trying to build brave following the guideline mentioned here, this is what I am facing right now. Any idea what wrong I am doing ?

[sangwoo108]

Hi, @debanjana-a11y . Could you confirm that you ran npm install and npm run init before running npm run build? Also, on Linux there are more prerequisites. https://github.com/brave/brave-browser/wiki/Linux-Development-Environment

[debanjana-a11y]

Hi, @debanjana-a11y . Could you confirm that you ran npm install and npm run init before running npm run build? Also, on Linux there are more prerequisites. https://github.com/brave/brave-browser/wiki/Linux-Development-Environment

Thanks @sangwoo108 for pointing out. Turned out that I did not properly follow the prerequisites.

Now I'm able to build but it is taking too much time. Is it normal ? I also tried running npm run test -- brave_browser_tests this also looks very slow in compiling stuffs. Like here is the compilation output after 3 hours, (still long way to go)

Did I miss something which makes them faster ?

[sangwoo108]

Hi, @debanjana-a11y . I'm so sorry for delayed response.

Now I'm able to build but it is taking too much time. Is it normal

Yes, it usually takes a lot of time. When I was building it with i5, it took longer than 5 hrs. So, I used to left my PC building browser all night long and go to bed. I think you're doing right unless it fails to build.

[XZ6H]

I would like to give this a shot. What all should be renamed - class, filename, preprocessor directives and delegates? or just the class?

[sangwoo108]

I would like to give this a shot. What all should be renamed - class, filename, preprocessor directives and delegates? or just the class?

Hi @XZ6H ! All of them should be changed

[SIDDHANT80NY]

Hi can I work on this ?

[XavierJDN]

Hey, Can I have more details where the service is?

[XavierJDN]

Hi, I think I resolved the issue. Can someone assign to me the issue? I also release that a factory and delegate service is connected to NTPCustomBackgroundImageService, so I also rename the factory and delegate service.

[bsclifton]

@XavierJDN sure - please submit your PR when ready and let us know 😄

[sangwoo108]

@XavierJDN I'm really sorry that I missed this. I cherry-picked your commits and created an PR so that our CI bots can go through tests. https://github.com/brave/brave-core/pull/17908

And I can't thank you enough for your time and effort for this 🙏

[XavierJDN]

@XavierJDN I'm really sorry that I missed this. I cherry-picked your commits and created an PR so that our CI bots can go through tests. brave/brave-core#17908

And I can't thank you enough for your time and effort for this pray

You're welcome. That was a pleasure.