brave-browser icon indicating copy to clipboard operation
brave-browser copied to clipboard

WebTorrent doesn't work with DCHECKs enabled on Linux

Open fallaciousreasoning opened this issue 1 year ago • 0 comments

Description

When DCHECKs are enabled, WebTorrent can't start torrents. This is because there are a couple of checks for non-zero buffer sizes in net/socket/udp_socket_posix.cc. This might also affect macOS, but I'm not sure.

Steps to Reproduce

In a development build, with DCHECKs enabled on Linux

  1. Open a torrent from https://webtorrent.io/free-torrents
  2. Click the Start Torrent button

Actual result:

The browser crashes

Expected result:

The browser does not crash

Reproduces how often:

Every time.

Desktop Brave version:

1.44.32 Chromium: 104.0.5112.81 (Developer Build) (64-bit)

Version/Channel Information:

  • Development (or any channel with DCHECKS enabled)
  • Probably only Linux (but maybe also macOS)

Other Additional Information:

  • Does the issue resolve itself when disabling Brave Shields?
  • Does the issue resolve itself when disabling Brave Rewards?
  • Is the issue reproducible on the latest version of Chrome?

Miscellaneous Information:

fallaciousreasoning avatar Aug 10 '22 03:08 fallaciousreasoning