brave-browser icon indicating copy to clipboard operation
brave-browser copied to clipboard

Published 20 hours ago • verified publisher icon brave

Implement declare geo (Phase 1)

Open Miyayes opened this issue 2 years ago • 1 comments

https://github.com/brave/internal/issues/894

  • [ ] Endpoints https://github.com/brave/brave-browser/issues/25484
  • [ ] UI/UX

Prerequisites:

  • https://github.com/brave/brave-browser/issues/24538
  • https://github.com/brave/brave-browser/issues/19361

Miyayes avatar Aug 09 '22 15:08 Miyayes

Likely split into UI issue/PR and backend. @zenparsing @szilardszaloki

Miyayes avatar Aug 10 '22 16:08 Miyayes

Verified with

Brave | 1.46.80 Chromium: 107.0.5304.68 (Official Build) beta (x86_64)
-- | --
Revision | a4e93e89d3b3df1be22214603fba846ad0183ca5-refs/branch-heads/5304@{#991}
OS | macOS Version 12.6.1 (Build 21G217)

Issues encountered:

  • https://github.com/brave/brave-browser/issues/26280

Verified test plan from https://github.com/brave/brave-core/pull/15199#issue-1384160311

New Profile Screenshots - PASSED

Using screenshots from https://github.com/brave/brave-core/pull/15199#issue-1384160311 compared to the below screens:

Example Example Example
3 5 6
New Profiles - PASSED
Success Case (non Japan region) - PASSED
  1. Clean profile 1.46.x, relaunch to pull griffin seed.
  2. Open the Rewards panel.
  3. Verify that initial onboarding modal is displayed.
  4. Click "Start Using Rewards".
  5. Verify that a country selection modal is displayed.
  6. Select a country from the drop-down.
  7. Click the "Continue" button.
  8. Verify that the Rewards tour is displayed.
  9. Open the Preferences file for the profile and verify that the "declared_geo" property has been set.
Step 3 Step 5 Step 6 Step 8 Step 9
3 5 6 8 Screen Shot 2022-10-26 at 11 36 49 AM
Logs 
[ REQUEST ]
> URL: https://grant.rewards.bravesoftware.com/v4/wallets
> Method: POST
> Content: {"geoCountry":"US"}
.........
[ RESPONSE - OnResponse ]
> Url: https://grant.rewards.bravesoftware.com/v4/wallets
> Result: Success
> HTTP Code: 201
> Body: {"paymentId":"200cbd45-d4b9-5009-8c6e-8dc4ffe2bf6e"}
Success Case (Japan region) - PASSED
  1. Clean profile 1.46.x, relaunch to pull griffin seed.
  2. Open the Rewards panel and click "Start Using Rewards".
  3. Select "Japan" from the list and click "Continue".
  4. In the Rewards tour, verify that the AC panel is not displayed.
  5. In the Rewards tour, verify that the bitFlyer promo is displayed.
  6. Navigate to the Rewards page.
  7. Verify that the AC settings section is not displayed.
Step 3 Step 4 Step 4 Step 4 Step 4 Step 4 Step 4 Step 5 Step 7
3 4a 4b 4c 4d 4e 4f 5 7
Error Case 1: Unexpected Error - PASSED
  1. Clean profile 1.46.x, relaunch to pull griffin seed.
  2. Open the Rewards panel and click "Start Using Rewards".
  3. Turn off Wifi.
  4. Select a country from the list and click "Continue".
  5. Verify that "Something went wrong" error is displayed.
Logs 
[ REQUEST ]
> URL: https://grant.rewards.bravesoftware.com/v4/wallets
> Method: POST
> Content: {"geoCountry":"US"}
.........
[ RESPONSE - OnResponse ]
> Url: https://grant.rewards.bravesoftware.com/v4/wallets
> Result: Error
> HTTP Code: -1
Screen Shot 2022-10-26 at 2 20 42 PM
Error Case 2: 403 Forbidden - PASSED
  1. Clean profile 1.46.x, relaunch to pull griffin seed.
  2. Open the Rewards panel and click "Start Using Rewards".
  3. Select unsupported country (like Iran) from the list and click "Continue".
  4. Verify that "Brave Rewards not available" error is displayed.

Encountered and logged https://github.com/brave/brave-browser/issues/26280.

Error message is shown as expected though: 403

Logs 
[ REQUEST ]
> URL: https://grant.rewards.bravesoftware.com/v4/wallets
> Method: POST
> Content: {"geoCountry":"IR"}
........
> Url: https://grant.rewards.bravesoftware.com/v4/wallets
> Result: Failure
> HTTP Code: 403
> Body: {"code":403,"message":"error creating rewards wallet: geo country is disabled"}
[7657:259:1026/103122.265798:VERBOSE9:logging_util.cc(135)] 
[ RESPONSE HEADERS ]
> Url: https://grant.rewards.bravesoftware.com/v4/wallets
Rewards Wallet Generation Endpoints - New Users - PASSED

Checked endpoint responses listed in spec from https://github.com/brave/internal/issues/894 under the "1. Rewards wallet generation endpoint (new users)" section.

201 Created - PASSED

See both Success cases above (for Japan and non-Japan regions):

[ REQUEST ]
> URL: https://grant.rewards.bravesoftware.com/v4/wallets
> Method: POST
> Content: {"geoCountry":"US"}
.........
[ RESPONSE - OnResponse ]
> Url: https://grant.rewards.bravesoftware.com/v4/wallets
> Result: Success
> HTTP Code: 201
> Body: {"paymentId":"200cbd45-d4b9-5009-8c6e-8dc4ffe2bf6e"}
409 Conflict - PASSED

Confirmed error message displayed as expected:

409 
[ REQUEST ]
> URL: https://grant.rewards.bravesoftware.com/v4/wallets
> Method: POST
> Content: {"geoCountry":"US"}
...........
[ RESPONSE - OnResponse ]
> Url: https://grant.rewards.bravesoftware.com/v4/wallets
> Result: Failure
> HTTP Code: 409
> Body: {"code":409,"message":"error creating rewards wallet: rewards wallet already exists"}

Brave | 1.46.81 Chromium: 107.0.5304.68 (Official Build) beta (x86_64)
-- | --
Revision | a4e93e89d3b3df1be22214603fba846ad0183ca5-refs/branch-heads/5304@{#991}
OS | macOS Version 12.6.1 (Build 21G217)
401 Unauthorized - PASSED

Confirmed error message displayed as expected:

401 
[ REQUEST ]
> URL: https://grant.rewards.bravesoftware.com/v4/wallets
> Method: POST
> Content: {"geoCountry":"US"}
.............
[ RESPONSE - OnResponse ]
> Url: https://grant.rewards.bravesoftware.com/v4/wallets
> Result: Failure
> HTTP Code: 401
> Body: {"code":401,"message":"error creating rewards wallet: failed to hex decode public key: encoding/hex: odd length hex string"}
403 Forbidden - PASSED

Confirmed error message displayed as expected, issue https://github.com/brave/brave-browser/issues/26280 logged for missing "Learn more" link.

403 
[ REQUEST ]
> URL: https://grant.rewards.bravesoftware.com/v4/wallets
> Method: POST
> Content: {"geoCountry":"IR"}
............
[ RESPONSE - OnResponse ]
> Url: https://grant.rewards.bravesoftware.com/v4/wallets
> Result: Failure
> HTTP Code: 403
> Body: {"code":403,"message":"error creating rewards wallet: geo country is disabled"}
400 Bad Request - PASSED

Confirmed error message displayed as expected:

400 
[ REQUEST ]
> URL: https://grant.rewards.bravesoftware.com/v4/wallets
> Method: POST
> Content: {"geoCountry":"US"}
........
[ RESPONSE - OnResponse ]
> Url: https://grant.rewards.bravesoftware.com/v4/wallets
> Result: Failure
> HTTP Code: 400
> Body: {"code":400,"message":"error creating rewards wallet: error geo country format must be ISO3166Alpha2"}
500 Internal Server Error - PASSED

Confirmed error message displayed as expected:

500 
[ REQUEST ]
> URL: https://grant.rewards.bravesoftware.com/v4/wallets
> Method: POST
> Content: {"geoCountry":"US"}
........
[ RESPONSE - OnResponse ]
> Url: https://grant.rewards.bravesoftware.com/v4/wallets
> Result: Failure
> HTTP Code: 500
Success Case: Country Already Declared - PASSED

With a fresh profile:

  1. Enable Rewards and close the browser.
  2. Open the Preferences file and clear the declared_geo field.
  3. Start the browser and open the Rewards panel.
  4. Select a country and click "Continue".
  5. Verify that the "Thank You" modal is displayed.
  6. Click "Close".
  7. Verify that Rewards panel content is displayed.
  8. Open the Preferences file for the profile and verify that the "declared_geo" property has been set.
Step 2 Step 4 Step 5 Step 7 Step 8
2 4 5 7 8
Logs from Step 1 
[ REQUEST ]
> URL: https://grant.rewards.bravesoftware.com/v4/wallets
> Method: POST
> Content: {"geoCountry":"GB"}
.........
[ RESPONSE - OnResponse ]
> Url: https://grant.rewards.bravesoftware.com/v4/wallets
> Result: Success
> HTTP Code: 201
> Body: {"paymentId":"2e1f2e55-5a01-5bf7-814a-1526d3e88383"}
Logs from Step 4 
[ REQUEST ]
> URL: https://grant.rewards.bravesoftware.com/v4/wallets/2e1f2e55-5a01-5bf7-814a-1526d3e88383
> Method: PATCH
> Content: {"geoCountry":"GB"}
..........
[ RESPONSE - OnResponse ]
> Url: https://grant.rewards.bravesoftware.com/v4/wallets/2e1f2e55-5a01-5bf7-814a-1526d3e88383
> Result: Failure
> HTTP Code: 409
> Body: {"code":409,"message":"error updating rewards wallet: error geo country has already been set for rewards wallet"}

Brave | 1.46.81 Chromium: 107.0.5304.68 (Official Build) beta (x86_64)
-- | --
Revision | a4e93e89d3b3df1be22214603fba846ad0183ca5-refs/branch-heads/5304@{#991}
OS | macOS Version 12.6.1 (Build 21G217)
Existing Profile Screenshots - PASSED

Using screenshots from https://github.com/brave/brave-core/pull/15199#issue-1384160311 compared to the below screens:

Example Example Example Example
1 2 3 4
Existing Profiles - PASSED
New Tab Page - PASSED
  1. Install 1.45.x (Release channel), relaunch to pull griffin seed.
  2. Enable Rewards.
  3. Close and "upgrade" to 1.46.x (rename profile to Beta).
  4. Open a new tab.
  5. Verify that the "Select your country" card is displayed.
  6. Click the "Continue" button.
  7. Verify that the Rewards panel is opened and the country selection modal is displayed.
Example Example Example Example
Screen Shot 2022-10-27 at 4 20 04 PM Screen Shot 2022-10-27 at 4 20 24 PM Screen Shot 2022-10-27 at 4 20 34 PM Screen Shot 2022-10-27 at 4 20 45 PM
Logs 
[ REQUEST ]
> URL: https://grant.rewards.bravesoftware.com/v4/wallets/8f8b2e84-d1a7-4c94-82d8-979d114e6de9
> Method: PATCH
> Content: {"geoCountry":"US"}
............
[ RESPONSE - OnResponse ]
> Url: https://grant.rewards.bravesoftware.com/v4/wallets/8f8b2e84-d1a7-4c94-82d8-979d114e6de9
> Result: Success
> HTTP Code: 200
Rewards Icon - PASSED
  1. Install 1.45.x (Release channel), relaunch to pull griffin seed.
  2. Enable Rewards, claim UGP grant and ensure no notification badges shown on rewards icon.
  3. Close and "upgrade" to 1.46.x (rename profile to Beta).
  4. Ensure that brave://flags/#brave-rewards-webui-panel is enabled (currently this is done via griffin study).
  5. Verify that a notification badge is displayed on the Rewards icon.
Step 2 Step 4 & 5
2 4-5
Success Case - PASSED

Follow above "Rewards Icon" case, then:

  1. Open the Rewards panel.
  2. Verify the "select country" modal is displayed.
  3. Select a country and click the "Continue" button.
  4. Verify that the "Thank you" modal is displayed.
  5. Click "Close".
  6. Verify that Rewards panel content is displayed.
  7. Open the Preferences file for the profile and verify that the "declared_geo" property has been set.
Step 2 Step 3 Step 4 Step 7
2 3 4 7
Logs 
[ REQUEST ]
> URL: https://grant.rewards.bravesoftware.com/v4/wallets/3ff5af87-a35a-4bd6-946c-91611b21cca5
> Method: PATCH
> Content: {"geoCountry":"US"}
.........
[ RESPONSE - OnResponse ]
> Url: https://grant.rewards.bravesoftware.com/v4/wallets/3ff5af87-a35a-4bd6-946c-91611b21cca5
> Result: Success
> HTTP Code: 200
Unexpected Error - PASSED

Follow above "Rewards Icon" case, then:

  1. Open the Rewards panel.
  2. Verify the "select country" modal is displayed.
  3. Turn off Wifi.
  4. Select a country and click the "Continue" button.
  5. Verify that "Something went wrong" error is displayed.
Step 2 Step 4 Step 5
2 4 5
Logs 
[ REQUEST ]
> URL: https://grant.rewards.bravesoftware.com/v4/wallets/0f27c58a-04d6-4147-b964-999689c0ef2a
> Method: PATCH
> Content: {"geoCountry":"US"}
..........
[ RESPONSE - OnResponse ]
> Url: https://grant.rewards.bravesoftware.com/v4/wallets/0f27c58a-04d6-4147-b964-999689c0ef2a
> Result: Error
> HTTP Code: -1
> Body:
Linked Wallet Case: bitFlyer - PASSED

Pre-req: be set to Japan for OS or use countryid flag.

  1. Install 1.45.x (Release channel), relaunch to pull griffin seed.
  2. Enable Rewards, claim UGP grant and ensure no notification badges shown on rewards icon.
  3. Link KYC'd bitFlyer account
  4. Close and "upgrade" to 1.46.x (rename profile to Beta).
  5. Ensure that brave://flags/#brave-rewards-webui-panel is enabled (currently this is done via griffin study).
  6. Verify that a notification badge is displayed on the Rewards icon.
  7. Open the Rewards panel.
  8. Verify that the only country available is Japan.
  9. Select Japan and click Continue.
  10. Confirm "Thank you" message is displayed.
  11. Close message and confirm panel information is shown.
Step 3 Step 5 Step 8 Step 10 Step 11
3 5 8 10 11
Logs from step 9 
[ REQUEST ]
> URL: https://grant.rewards.bravesoftware.com/v4/wallets/e0960f34-46fe-4f0a-9081-711abdfdff93
> Method: PATCH
> Content: {"geoCountry":"JP"}
...........
[ RESPONSE - OnResponse ]
> Url: https://grant.rewards.bravesoftware.com/v4/wallets/e0960f34-46fe-4f0a-9081-711abdfdff93
> Result: Success
> HTTP Code: 200
Linked Wallet Case: Gemini - PASSED
  1. Install 1.45.x (Release channel), relaunch to pull griffin seed.
  2. Enable Rewards, claim UGP grant and ensure no notification badges shown on rewards icon.
  3. Link KYC'd Gemini account
  4. Close and "upgrade" to 1.46.x (rename profile to Beta).
  5. Ensure that brave://flags/#brave-rewards-webui-panel is enabled (currently this is done via griffin study).
  6. Verify that a notification badge is displayed on the Rewards icon.
  7. Open the Rewards panel.
  8. Verify Japan is not available in the list.
  9. Select the country your account is KYC'd for and click Continue.
  10. Confirm "Thank you" message is displayed.
  11. Close message and confirm panel information is shown.
Step 3 Step 5 Step 8 Step 10 Step 11
3 5 8 10 11
Logs for step 9 
[ REQUEST ]
> URL: https://grant.rewards.bravesoftware.com/v4/wallets/3db437ae-d87a-4486-826a-20e7f1ee5459
> Method: PATCH
> Content: {"geoCountry":"US"}
.............
[ RESPONSE - OnResponse ]
> Url: https://grant.rewards.bravesoftware.com/v4/wallets/3db437ae-d87a-4486-826a-20e7f1ee5459
> Result: Failure
> HTTP Code: 409

Note, in above logs the 409 response and UI shown is expected per doc linked in https://github.com/brave/internal/issues/894.

Linked Wallet Case: Uphold - PASSED
  1. Install 1.45.x (Release channel), relaunch to pull griffin seed.
  2. Enable Rewards, claim UGP grant and ensure no notification badges shown on rewards icon.
  3. Link KYC'd Uphold account
  4. Close and "upgrade" to 1.46.x (rename profile to Beta).
  5. Ensure that brave://flags/#brave-rewards-webui-panel is enabled (currently this is done via griffin study).
  6. Verify that a notification badge is displayed on the Rewards icon.
  7. Open the Rewards panel.
  8. Verify Japan is not available in the list.
  9. Select the country your account is KYC'd for and click Continue.
  10. Confirm "Thank you" message is displayed.
  11. Close message and confirm panel information is shown.
Step 3 Step 5 Step 8 Step 10 Step 11
3 5 8 10 11
Logs for step 9 
[ REQUEST ]
> URL: https://grant.rewards.bravesoftware.com/v4/wallets/0712f42f-6e3e-44fa-adee-56bb16716515
> Method: PATCH
> Content: {"geoCountry":"US"}
.........
[ RESPONSE - OnResponse ]
> Url: https://grant.rewards.bravesoftware.com/v4/wallets/0712f42f-6e3e-44fa-adee-56bb16716515
> Result: Failure
> HTTP Code: 409
> Body: {"code":409,"message":"error updating rewards wallet: error geo country has already been set for rewards wallet"}

Note, in above logs the 409 response and UI shown is expected per doc linked in https://github.com/brave/internal/issues/894.

Independent Declare Endpoints - Existing Users - PASSED

Checked endpoint responses listed in spec from https://github.com/brave/internal/issues/894 under the "2. Independent declare endpoint (existing users)" section.

200 OK - PASSED

See "Success Case" above. Generally joined rewards with 1.45.x, "upgraded" to 1.46.x, and selected my country.

[ REQUEST ]
> URL: https://grant.rewards.bravesoftware.com/v4/wallets/08b2725d-30ff-4b89-a0e8-0552cc7bbe76
> Method: PATCH
> Content: {"geoCountry":"US"}
............
[ RESPONSE - OnResponse ]
> Url: https://grant.rewards.bravesoftware.com/v4/wallets/08b2725d-30ff-4b89-a0e8-0552cc7bbe76
> Result: Success
> HTTP Code: 200
> Body:
200
409 Conflict - PASSED

Confirmed no error message displayed as expected per the doc linked in https://github.com/brave/internal/issues/894. See "Linked Wallet Case: Uphold" and "Linked Wallet Case: Gemini" above.

Generally joined rewards with 1.45.x, linked staging Uphold account. Upgraded to 1.46.x and declared my KYC'd country.

[ REQUEST ]
> URL: https://grant.rewards.bravesoftware.com/v4/wallets/d44dd5ef-4c89-439f-a257-c3735811e355
> Method: PATCH
> Content: {"geoCountry":"US"}
..............
[ RESPONSE - OnResponse ]
> Url: https://grant.rewards.bravesoftware.com/v4/wallets/d44dd5ef-4c89-439f-a257-c3735811e355
> Result: Failure
> HTTP Code: 409
> Body: {"code":409,"message":"error updating rewards wallet: error geo country has already been set for rewards wallet"}
409
401 Unauthorized - PASSED

Confirmed error message displayed as expected. Generally joined rewards with 1.45.x, set up Charles Proxy rewrite rule, "upgraded" to 1.46.x, and selected my country.

[ REQUEST ]
> URL: https://grant.rewards.bravesoftware.com/v4/wallets/d44dd5ef-4c89-439f-a257-c3735811e355
> Method: PATCH
> Content: {"geoCountry":"US"}
............
[ RESPONSE - OnResponse ]
> Url: https://grant.rewards.bravesoftware.com/v4/wallets/d44dd5ef-4c89-439f-a257-c3735811e355
> Result: Failure
> HTTP Code: 401
> Body: {"code":401,"message":"signature must be present for signed middleware"}
401
403 Case 1 - PASSED

Confirmed error message displayed as expected. Generally joined rewards with 1.45.x, set up Charles Proxy rewrite rule, "upgraded" to 1.46.x, and selected my country.

[ REQUEST ]
> URL: https://grant.rewards.bravesoftware.com/v4/wallets/59eef81b-e8a9-4e77-aa2f-616aa955f316
> Method: PATCH
> Content: {"geoCountry":"US"}
.................
[ RESPONSE - OnResponse ]
> Url: https://grant.rewards.bravesoftware.com/v4/wallets/59eef81b-e8a9-4e77-aa2f-616aa955f316
> Result: Failure
> HTTP Code: 403
> Body: {"code":403,"message":"error updating rewards wallet: payment id does not match http signature key id"}
403
403 Case 2 - PASSED

Confirmed error message displayed as expected. Generally joined rewards with 1.45.x, set up Charles Proxy rewrite rule, "upgraded" to 1.46.x, and selected my country.

[ REQUEST ]
> URL: https://grant.rewards.bravesoftware.com/v4/wallets/f3abb1e7-8d7f-4cf7-9991-c7935b5a8507
> Method: PATCH
> Content: {"geoCountry":"US"}
...........
[ RESPONSE - OnResponse ]
> Url: https://grant.rewards.bravesoftware.com/v4/wallets/f3abb1e7-8d7f-4cf7-9991-c7935b5a8507
> Result: Failure
> HTTP Code: 403
> Body: {"code":403,"message":"request signature verification failure"}
403-2
400 Bad Request - PASSED

Confirmed error message displayed as expected. Generally joined rewards with 1.45.x, set up Charles Proxy rewrite rule, "upgraded" to 1.46.x, and selected my country.

[ REQUEST ]
> URL: https://grant.rewards.bravesoftware.com/v4/wallets/59eef81b-e8a9-4e77-aa2f-616aa955f316
> Method: PATCH
> Content: {"geoCountry":"US"}
..............
[ RESPONSE - OnResponse ]
> Url: https://grant.rewards.bravesoftware.com/v4/wallets/59eef81b-e8a9-4e77-aa2f-616aa955f316
> Result: Failure
> HTTP Code: 400
> Body: {"code":400,"message":"error creating rewards wallet: error geo country format must be ISO3166Alpha2"}
400
500 Internal Server Error - PASSED

Confirmed error message displayed as expected. Generally joined rewards with 1.45.x, set up Charles Proxy rewrite rule, "upgraded" to 1.46.x, and selected my country.

[ REQUEST ]
> URL: https://grant.rewards.bravesoftware.com/v4/wallets/59eef81b-e8a9-4e77-aa2f-616aa955f316
> Method: PATCH
> Content: {"geoCountry":"US"}
................
[36301:259:1031/141218.104480:VERBOSE6:logging_util.cc(134)] 
[ RESPONSE - OnResponse ]
> Url: https://grant.rewards.bravesoftware.com/v4/wallets/59eef81b-e8a9-4e77-aa2f-616aa955f316
> Result: Failure
> HTTP Code: 500
500
Close button - PASSED
  1. Clean profile 1.46.x, relaunch to pull griffin seed.
  2. Open the Rewards panel and click "Start Using Rewards".
  3. Turn off Wifi.
  4. Select a country from the list and click "Continue".
  5. Verify that "Something went wrong" error is displayed.
  6. Select "Close" button
  7. Confirm you are taken back to the country selection screen to try again.
  8. Re-enable wifi.
  9. Try selecting your country again.
  10. This time country selection succeeds and user is taken to onboarding.
Step 5 Step 9 Step 10
5 9 10

LaurenWags avatar Oct 26 '22 14:10 LaurenWags

@brave/qa-team see this post for more information: https://bravesoftware.slack.com/archives/GAA4017R7/p1667492572270059

LaurenWags avatar Nov 03 '22 16:11 LaurenWags

Verification PASSED on

Brave | 1.46.99 Chromium: 107.0.5304.91 (Official Build) beta (64-bit)
-- | --
Revision | 3d5948960d62418160796d5831a4d2d7d6c90fa8-refs/branch-heads/5304@{#1097}
OS | Windows 10 Version 21H2 (Build 19044.2130)
  • Verified the test plan from https://github.com/brave/brave-core/pull/15199

Clean profile

Success Case: Country Already Declared - PASSED

With a fresh profile:

  1. Enable Rewards and close the browser.
  2. Open the Preferences file and clear the declared_geo field.
  3. Start the browser and open the Rewards panel.
  4. Select a country and click "Continue".
  5. Verify that the "Thank You" modal is displayed.
  6. Click "Close".
  7. Verify that Rewards panel content is displayed.
  8. Open the Preferences file for the profile and verify that the "declared_geo" property has been set.
Step 2 Step 4 Step 5 Step 7 Step 8
image image image image image
Logs from Step 1 
[ REQUEST ]
> URL: https://grant.rewards.bravesoftware.com/v4/wallets
> Method: POST
> Content: {"geoCountry":"US"}
.........
[ RESPONSE - OnResponse ]
> Url: https://grant.rewards.bravesoftware.com/v4/wallets
> Result: Success
> HTTP Code: 201
> Body: {"paymentId":"801c3ddf-8661-5e7c-80d0-7e4dcf2c863c"}
[17548:3804:1110/140222.351:VERBOSE9:logging_util.cc(135)]
Logs from Step 4 
[ REQUEST ]
> URL: https://grant.rewards.bravesoftware.com/v4/wallets/213978a2-8973-5f4d-ab09-2ad78804f5b7
> Method: PATCH
> Content: {"geoCountry":"AU"}
-----
[ RESPONSE - OnResponse ]
> Url: https://grant.rewards.bravesoftware.com/v4/wallets/213978a2-8973-5f4d-ab09-2ad78804f5b7
> Result: Failure
> HTTP Code: 409
> Body: {"code":409,"message":"error updating rewards wallet: error geo country has already been set for rewards wallet"}
[19008:12312:1110/142712.966:VERBOSE9:logging_util.cc(135)]
New Profiles - PASSED
Success Case (non Japan region) - PASSED
  1. Clean profile 1.46.x, relaunch to pull griffin seed.
  2. Open the Rewards panel.
  3. Verify that initial onboarding modal is displayed.
  4. Click "Start Using Rewards".
  5. Verify that a country selection modal is displayed.
  6. Select a country from the drop-down.
  7. Click the "Continue" button.
  8. Verify that the Rewards tour is displayed.
  9. Open the Preferences file for the profile and verify that the "declared_geo" property has been set.
Step 3 Step 5 Step 6 Step 8 Step 9
image image image image image
Logs 
[ REQUEST ]
> URL: https://grant.rewards.bravesoftware.com/v4/wallets
> Method: POST
> Content: {"geoCountry":"GB"}
> Content Type: application/json; charset=utf-8
.........
[ RESPONSE - OnResponse ]
> Url: https://grant.rewards.bravesoftware.com/v4/wallets
> Result: Success
> HTTP Code: 201
> Body: {"paymentId":"1d3afd95-7ded-553a-bcad-cd1e1156989a"}
[7252:5196:1110/160144.154:VERBOSE9:logging_util.cc(135)]
Success Case (Japan region) - PASSED
  1. Clean profile 1.46.x, relaunch to pull griffin seed.
  2. Open the Rewards panel and click "Start Using Rewards".
  3. Select "Japan" from the list and click "Continue".
  4. In the Rewards tour, verify that the AC panel is not displayed.
  5. In the Rewards tour, verify that the bitFlyer promo is displayed.
  6. Navigate to the Rewards page.
  7. Verify that the AC settings section is not displayed.
Step 3 Step 4 Step 4 Step 4 Step 4 Step 4 Step 4 Step 5 Step 7
image image image image image image image image image
Error Case 1: Unexpected Error - PASSED
  1. Clean profile 1.46.x, relaunch to pull griffin seed.
  2. Open the Rewards panel and click "Start Using Rewards".
  3. Turn off Wifi.
  4. Select a country from the list and click "Continue".
  5. Verify that "Something went wrong" error is displayed.
Logs 
[ REQUEST ]
> URL: https://grant.rewards.bravesoftware.com/v4/wallets
> Method: POST
> Content: {"geoCountry":"AD"}
.........
[ RESPONSE - OnResponse ]
> Url: https://grant.rewards.bravesoftware.com/v4/wallets
> Result: Error
> HTTP Code: -1
> Body:
[14424:13136:1110/162145.613:VERBOSE9:logging_util.cc(135)]

image

Error Case 2: 403 Forbidden - PASSED
  1. Clean profile 1.46.x, relaunch to pull griffin seed.
  2. Open the Rewards panel and click "Start Using Rewards".
  3. Select unsupported country (like Iran) from the list and click "Continue".
  4. Verify that "Brave Rewards not available" error is displayed.

Error message is shown as expected though:

image

Logs 
[ REQUEST ]
> URL: https://grant.rewards.bravesoftware.com/v4/wallets
> Method: POST
> Content: {"geoCountry":"IR"}
........
[ RESPONSE - OnResponse ]
> Url: https://grant.rewards.bravesoftware.com/v4/wallets
> Result: Failure
> HTTP Code: 403
> Body: {"code":403,"message":"error creating rewards wallet: geo country is disabled"}
[14456:1080:1110/163135.627:VERBOSE9:logging_util.cc(135)]

Existing profile

Existing Profile Screenshots - PASSED

Using screenshots from https://github.com/brave/brave-core/pull/15199#issue-1384160311 compared to the below screens:

Example Example Example Example
image image image image
Existing Profiles - PASSED
New Tab Page - PASSED
  1. Install 1.45.x (Release channel), relaunch to pull griffin seed.
  2. Enable Rewards.
  3. Close and "upgrade" to 1.46.x (rename profile to Beta).
  4. Open a new tab.
  5. Verify that the "Select your country" card is displayed.
  6. Click the "Continue" button.
  7. Verify that the Rewards panel is opened and the country selection modal is displayed.
Example Example Example Example
image image image image
Logs 
[ REQUEST ]
> URL: https://grant.rewards.bravesoftware.com/v4/wallets/8f8b2e84-d1a7-4c94-82d8-979d114e6de9
> Method: PATCH
> Content: {"geoCountry":"US"}
............
[ RESPONSE - OnResponse ]
> Url: https://grant.rewards.bravesoftware.com/v4/wallets/8f8b2e84-d1a7-4c94-82d8-979d114e6de9
> Result: Success
> HTTP Code: 200
Rewards Icon - PASSED
  1. Install 1.45.x (Release channel), relaunch to pull griffin seed.
  2. Enable Rewards, claim UGP grant and ensure no notification badges shown on rewards icon.
  3. Close and "upgrade" to 1.46.x (rename profile to Beta).
  4. Ensure that brave://flags/#brave-rewards-webui-panel is enabled (currently this is done via griffin study).
  5. Verify that a notification badge is displayed on the Rewards icon.
Step 2 Step 4 & 5
image image
Success Case - PASSED

Follow above "Rewards Icon" case, then:

  1. Open the Rewards panel.
  2. Verify the "select country" modal is displayed.
  3. Select a country and click the "Continue" button.
  4. Verify that the "Thank you" modal is displayed.
  5. Click "Close".
  6. Verify that Rewards panel content is displayed.
  7. Open the Preferences file for the profile and verify that the "declared_geo" property has been set.
Step 2 Step 3 Step 4 Step 7
image image image image
Logs 
[ REQUEST ]
> URL: https://grant.rewards.bravesoftware.com/v4/wallets/e2f08354-b167-4c84-89d0-79861c6dc77c
> Method: PATCH
> Content: {"geoCountry":"DE"}
.........
[ RESPONSE - OnResponse ]
> Url: https://grant.rewards.bravesoftware.com/v4/wallets/e2f08354-b167-4c84-89d0-79861c6dc77c
> Result: Success
> HTTP Code: 200
> Body:
[19980:5548:1110/171211.589:VERBOSE9:logging_util.cc(135)]
Unexpected Error - PASSED

Follow above "Rewards Icon" case, then:

  1. Open the Rewards panel.
  2. Verify the "select country" modal is displayed.
  3. Turn off Wifi.
  4. Select a country and click the "Continue" button.
  5. Verify that "Something went wrong" error is displayed.
Step 2 Step 4 Step 5
image image image
Logs 
[ REQUEST ]
> URL: https://grant.rewards.bravesoftware.com/v4/wallets/e96ed688-f557-4d55-be55-50b88e8fc0a5
> Method: PATCH
> Content: {"geoCountry":"IN"}
..........
[ RESPONSE - OnResponse ]
> Url: https://grant.rewards.bravesoftware.com/v4/wallets/e96ed688-f557-4d55-be55-50b88e8fc0a5
> Result: Error
> HTTP Code: -1
> Body:
[19944:484:1110/172026.570:VERBOSE9:logging_util.cc(135)]
Linked Wallet Case: bitFlyer - PASSED

Pre-req: be set to Japan for OS or use countryid flag.

  1. Install 1.45.x (Release channel), relaunch to pull griffin seed.
  2. Enable Rewards, claim UGP grant and ensure no notification badges shown on rewards icon.
  3. Link KYC'd bitFlyer account
  4. Close and "upgrade" to 1.46.x (rename profile to Beta).
  5. Ensure that brave://flags/#brave-rewards-webui-panel is enabled (currently this is done via griffin study).
  6. Verify that a notification badge is displayed on the Rewards icon.
  7. Open the Rewards panel.
  8. Verify that the only country available is Japan.
  9. Select Japan and click Continue.
  10. Confirm "Thank you" message is displayed.
  11. Close message and confirm panel information is shown.
Step 3 Step 5 Step 8 Step 10 Step 11
image image image image image
Logs from step 9 
[ REQUEST ]
> URL: https://grant.rewards.bravesoftware.com/v4/wallets/8bc0999d-7e4c-46bf-9fc8-3cdb4fceae09
> Method: PATCH
> Content: {"geoCountry":"JP"}
...........

[ RESPONSE - OnResponse ]
> Url: https://grant.rewards.bravesoftware.com/v4/wallets/8bc0999d-7e4c-46bf-9fc8-3cdb4fceae09
> Result: Failure
> HTTP Code: 409
> Body: {"code":409,"message":"error updating rewards wallet: error geo country has already been set for rewards wallet"}
[22588:6352:1110/180345.735:VERBOSE9:logging_util.cc(135)]
Linked Wallet Case: Gemini - PASSED
  1. Install 1.45.x (Release channel), relaunch to pull griffin seed.
  2. Enable Rewards, claim UGP grant and ensure no notification badges shown on rewards icon.
  3. Link KYC'd Gemini account
  4. Close and "upgrade" to 1.46.x (rename profile to Beta).
  5. Ensure that brave://flags/#brave-rewards-webui-panel is enabled (currently this is done via griffin study).
  6. Verify that a notification badge is displayed on the Rewards icon.
  7. Open the Rewards panel.
  8. Verify Japan is not available in the list.
  9. Select the country your account is KYC'd for and click Continue.
  10. Confirm "Thank you" message is displayed.
  11. Close message and confirm panel information is shown.
Step 3 Step 5 Step 8 Step 10 Step 11
image image image image image
Logs for step 9 
[ REQUEST ]
> URL: https://grant.rewards.bravesoftware.com/v4/wallets/3ab05219-14ff-449c-af11-63a756c39949
> Method: PATCH
> Content: {"geoCountry":"US"}
.............
[ RESPONSE - OnResponse ]
> Url: https://grant.rewards.bravesoftware.com/v4/wallets/3ab05219-14ff-449c-af11-63a756c39949
> Result: Failure
> HTTP Code: 409
> Body: {"code":409,"message":"error updating rewards wallet: error geo country has already been set for rewards wallet"}
[6196:22192:1110/174721.468:VERBOSE9:logging_util.cc(135)]

Note, in above logs the 409 response and UI shown is expected per doc linked in https://github.com/brave/internal/issues/894.

Linked Wallet Case: Uphold - PASSED
  1. Install 1.45.x (Release channel), relaunch to pull griffin seed.
  2. Enable Rewards, claim UGP grant and ensure no notification badges shown on rewards icon.
  3. Link KYC'd Uphold account
  4. Close and "upgrade" to 1.46.x (rename profile to Beta).
  5. Ensure that brave://flags/#brave-rewards-webui-panel is enabled (currently this is done via griffin study).
  6. Verify that a notification badge is displayed on the Rewards icon.
  7. Open the Rewards panel.
  8. Verify Japan is not available in the list.
  9. Select the country your account is KYC'd for and click Continue.
  10. Confirm "Thank you" message is displayed.
  11. Close message and confirm panel information is shown.
Step 3 Step 5 Step 8 Step 10 Step 11
image image image image image
Logs for step 9 
[ REQUEST ]
> URL: https://grant.rewards.bravesoftware.com/v4/wallets/548c2ec2-9da5-41be-a71d-ab80029e7c20
> Method: PATCH
> Content: {"geoCountry":"IN"}
.........
[ RESPONSE - OnResponse ]
> Url: https://grant.rewards.bravesoftware.com/v4/wallets/548c2ec2-9da5-41be-a71d-ab80029e7c20
> Result: Failure
> HTTP Code: 409
> Body: {"code":409,"message":"error updating rewards wallet: error geo country has already been set for rewards wallet"}
[18580:19748:1110/175534.111:VERBOSE9:logging_util.cc(135)]

Note, in above logs the 409 response and UI shown is expected per doc linked in https://github.com/brave/internal/issues/894.

GeetaSarvadnya avatar Nov 09 '22 13:11 GeetaSarvadnya

Verification passed on

Brave 1.46.121 Chromium: 108.0.5359.48 (Official Build) beta (64-bit)
Revision 18ceeca0d99318e70c00d2e04d88aa55488b5c63-refs/branch-heads/5359@{#854}
OS Ubuntu 18.04 LTS
  • Verified the test plan from https://github.com/brave/brave-core/pull/15199

Clean profile

Success Case: Country Already Declared - PASSED

With a fresh profile:

  1. Enable Rewards and close the browser.
  2. Open the Preferences file and clear the declared_geo field.
  3. Start the browser and open the Rewards panel.
  4. Select a country and click "Continue".
  5. Verify that the "Thank You" modal is displayed.
  6. Click "Close".
  7. Verify that Rewards panel content is displayed.
  8. Open the Preferences file for the profile and verify that the "declared_geo" property has been set.

image image image image image

Logs from Step 4 
[12392:12392:1123/204625.763850:VERBOSE5:ledger_impl.cc(117)] 
[ REQUEST ]
> URL: https://grant.rewards.brave.com/v4/wallets/b8f6e33e-4ae2-59d5-8b47-2db91cb37997
> Method: PATCH
> Content: {"geoCountry":"US"}
> Content Type: application/json; charset=utf-8
> Header digest: SHA-256=3qb2VxsOc3ttZ2t4p2mnCmhKFFOCcXpkoqc/iirXnIA=
> Header signature: keyId="b8f6e33e-4ae2-59d5-8b47-2db91cb37997",algorithm="ed25519",headers="digest (request-target)",signature="/jDC8lAkVe2Z2f//v8dyzHGptpbxz3OJfndHNmblRH2VLES0pfLBIM4vb8O3QihmsZnbo+nB+XIhbrEeoXwcCA=="
> Header accept: application/json
[12392:12392:1123/204626.416915:VERBOSE6:logging_util.cc(134)] 
[ RESPONSE - OnResponse ]
> Url: https://grant.rewards.brave.com/v4/wallets/b8f6e33e-4ae2-59d5-8b47-2db91cb37997
> Result: Failure
> HTTP Code: 409
> Body: {"code":409,"message":"error updating rewards wallet: error geo country has already been set for rewards wallet"}
New Profiles - PASSED
Success Case (non Japan region) - PASSED
  1. Clean profile 1.46.x, relaunch to pull griffin seed.
  2. Open the Rewards panel.
  3. Verify that initial onboarding modal is displayed.
  4. Click "Start Using Rewards".
  5. Verify that a country selection modal is displayed.
  6. Select a country from the drop-down.
  7. Click the "Continue" button.
  8. Verify that the Rewards tour is displayed.
  9. Open the Preferences file for the profile and verify that the "declared_geo" property has been set.

image

Logs 
[12658:12658:1123/204835.176630:VERBOSE5:ledger_impl.cc(117)] 
[ REQUEST ]
> URL: https://grant.rewards.brave.com/v4/wallets
> Method: POST
> Content: {"geoCountry":"US"}
> Content Type: application/json; charset=utf-8
> Header digest: SHA-256=3qb2VxsOc3ttZ2t4p2mnCmhKFFOCcXpkoqc/iirXnIA=
> Header signature: keyId="f0a8c411d021c4b9644b859638683129f3de054fa8329776f10924a1044b55ab",algorithm="ed25519",headers="digest (request-target)",signature="ekVv3s2HpkUqWJ15ngRL8YcTmfNQHFRxfQSKLBvon0X0u8JxcYto3gCHbq7jy4tToJNa4oLmTjUhQRLga0n5Ag=="
> Header accept: application/json
[12658:12658:1123/204836.526255:VERBOSE6:logging_util.cc(134)] 
[ RESPONSE - OnResponse ]
> Url: https://grant.rewards.brave.com/v4/wallets
> Result: Success
> HTTP Code: 201
> Body: {"paymentId":"1f4e4500-e0a2-5071-9a3a-464c291e0830"}
Success Case (Japan region) - PASSED
  1. Clean profile 1.46.x, relaunch to pull griffin seed.
  2. Open the Rewards panel and click "Start Using Rewards".
  3. Select "Japan" from the list and click "Continue".
  4. In the Rewards tour, verify that the AC panel is not displayed.
  5. In the Rewards tour, verify that the bitFlyer promo is displayed.
  6. Navigate to the Rewards page.
  7. Verify that the AC settings section is not displayed.

image image

Error Case 1: Unexpected Error - PASSED
  1. Clean profile 1.46.x, relaunch to pull griffin seed.
  2. Open the Rewards panel and click "Start Using Rewards".
  3. Turn off Wifi.
  4. Select a country from the list and click "Continue".
  5. Verify that "Something went wrong" error is displayed.
Logs 
[14999:14999:1123/213443.692322:VERBOSE5:ledger_impl.cc(117)] 
[ REQUEST ]
> URL: https://grant.rewards.brave.com/v4/wallets
> Method: POST
> Content: {"geoCountry":"US"}
> Content Type: application/json; charset=utf-8
> Header digest: SHA-256=3qb2VxsOc3ttZ2t4p2mnCmhKFFOCcXpkoqc/iirXnIA=
> Header signature: keyId="7aa3cf7bf7f792c16f5a74c88bef9a31233a0d67c3a398fe79a31c52cf61cec1",algorithm="ed25519",headers="digest (request-target)",signature="3XUyq3BSFRsAKiknIPhiSjDKGlmpK5Wy6txQw6xtvtU/uoNJMZmWpoWC96JYGxtqXbL35QO8RIFkkGq4GhpOAg=="
> Header accept: application/json
[ RESPONSE - OnResponse ]
> Url: https://grant.rewards.brave.com/v4/wallets
> Result: Error
> HTTP Code: -1
> Body:

image

Error Case 2: 403 Forbidden - PASSED
  1. Clean profile 1.46.x, relaunch to pull griffin seed.
  2. Open the Rewards panel and click "Start Using Rewards".
  3. Select unsupported country (like Iran) from the list and click "Continue".
  4. Verify that "Brave Rewards not available" error is displayed.

Error message is shown as expected though:

image

Logs 
[15607:15607:1123/214305.976794:VERBOSE6:logging_util.cc(134)] 
[ RESPONSE - OnResponse ]
> Url: https://grant.rewards.brave.com/v4/wallets
> Result: Failure
> HTTP Code: 403
> Body: {"code":403,"message":"error creating rewards wallet: geo country is disabled"}
[15607:15607:1123/214305.984858:INFO:post_wallets.cc(54)] Wallet generation disabled!
[15607:15607:1123/214305.993171:INFO:wallet_create.cc(103)] Failed to create Rewards wallet!

Existing profile

Existing Profile Screenshots - PASSED

Using screenshots from https://github.com/brave/brave-core/pull/15199#issue-1384160311 compared to the below screens:

image image

Existing Profiles - PASSED
New Tab Page - PASSED
  1. Install 1.45.x (Release channel), relaunch to pull griffin seed.
  2. Enable Rewards.
  3. Close and "upgrade" to 1.46.x (rename profile to Beta).
  4. Open a new tab.
  5. Verify that the "Select your country" card is displayed.
  6. Click the "Continue" button.
  7. Verify that the Rewards panel is opened and the country selection modal is displayed.

image image image image

Logs 
[17791:17791:1123/220018.437145:VERBOSE5:ledger_impl.cc(117)] 
[ REQUEST ]
> URL: https://grant.rewards.brave.com/v4/wallets/3a18705f-0e4f-4956-ab49-418f35b5b077
> Method: PATCH
> Content: {"geoCountry":"PL"}
> Content Type: application/json; charset=utf-8
> Header digest: SHA-256=BeW/FSPnGAMv94rXcHDM3nTkJLSiAPy4Z1dZOSiieBk=
> Header signature: keyId="3a18705f-0e4f-4956-ab49-418f35b5b077",algorithm="ed25519",headers="digest (request-target)",signature="691dIf649PboBioBIGV2PWBVE7Ue/gRHfsSBmtf+iI2wtVp8Me8/sK0l4iCo72gtae0xzituUCSrSTMpvBNEDg=="
> Header accept: application/json
[17791:17791:1123/220019.054921:VERBOSE6:logging_util.cc(134)] 
[ RESPONSE - OnResponse ]
> Url: https://grant.rewards.brave.com/v4/wallets/3a18705f-0e4f-4956-ab49-418f35b5b077
> Result: Success
> HTTP Code: 200
> Body:
Rewards Icon - PASSED
  1. Install 1.45.x (Release channel), relaunch to pull griffin seed.
  2. Enable Rewards, claim UGP grant and ensure no notification badges shown on rewards icon.
  3. Close and "upgrade" to 1.46.x (rename profile to Beta).
  4. Ensure that brave://flags/#brave-rewards-webui-panel is enabled (currently this is done via griffin study).
  5. Verify that a notification badge is displayed on the Rewards icon.

image

Success Case - PASSED

Follow above "Rewards Icon" case, then:

  1. Open the Rewards panel.
  2. Verify the "select country" modal is displayed.
  3. Select a country and click the "Continue" button.
  4. Verify that the "Thank you" modal is displayed.
  5. Click "Close".
  6. Verify that Rewards panel content is displayed.
  7. Open the Preferences file for the profile and verify that the "declared_geo" property has been set.

image image image image

Logs 
[ REQUEST ]
> URL: https://grant.rewards.bravesoftware.com/v4/wallets/0245521f-cede-4ce1-966c-a8b5b83ce7e7
> Method: PATCH
> Content: {"geoCountry":"US"}
> Content Type: application/json; charset=utf-8
> Header digest: SHA-256=3qb2VxsOc3ttZ2t4p2mnCmhKFFOCcXpkoqc/iirXnIA=
> Header signature: keyId="0245521f-cede-4ce1-966c-a8b5b83ce7e7",algorithm="ed25519",headers="digest (request-target)",signature="G5gm4oWQAaMtzLSfbl7gSQdesFEpF90a2z79Dmmem5kyahW/I9b9QO/CkKx9+RvaPVEgABY+DYaWOlRLUJy2AQ=="
> Header accept: application/json
[19254:19254:1123/220839.057983:INFO:rewards_service_impl.cc(1166)] Response sanitization error: Invalid top-level type
[19254:19254:1123/220839.059879:VERBOSE6:logging_util.cc(134)] 
[ RESPONSE - OnResponse ]
> Url: https://grant.rewards.bravesoftware.com/v4/wallets/0245521f-cede-4ce1-966c-a8b5b83ce7e7
> Result: Success
> HTTP Code: 200
Unexpected Error - PASSED

Follow above "Rewards Icon" case, then:

  1. Open the Rewards panel.
  2. Verify the "select country" modal is displayed.
  3. Turn off Wifi.
  4. Select a country and click the "Continue" button.
  5. Verify that "Something went wrong" error is displayed.

image image image

Logs 
[ REQUEST ]
> URL: https://grant.rewards.bravesoftware.com/v4/wallets/08b987c9-c2c2-43a1-b436-b54fa623c992
> Method: PATCH
> Content: {"geoCountry":"US"}
> Content Type: application/json; charset=utf-8
> Header digest: SHA-256=3qb2VxsOc3ttZ2t4p2mnCmhKFFOCcXpkoqc/iirXnIA=
> Header signature: keyId="08b987c9-c2c2-43a1-b436-b54fa623c992",algorithm="ed25519",headers="digest (request-target)",signature="nuPuGQXdjctMZadIr5RDMuNrINrRrlWOYZwmZEval6IHRr0Bpzp/9150l+cg3dd2jQ2PHLm2eR4rwPBDZ2ooCg=="
> Header accept: application/json
[20100:20100:1123/221710.475065:INFO:logging_util.cc(102)] Network error (net::ERR_INTERNET_DISCONNECTED)
[20100:20100:1123/221710.491291:VERBOSE6:logging_util.cc(134)] 
[ RESPONSE - OnResponse ]
> Url: https://grant.rewards.bravesoftware.com/v4/wallets/08b987c9-c2c2-43a1-b436-b54fa623c992
> Result: Error
> HTTP Code: -1
> Body:
Linked Wallet Case: bitFlyer - PASSED

Pre-req: be set to Japan for OS or use countryid flag.

  1. Install 1.45.x (Release channel), relaunch to pull griffin seed.
  2. Enable Rewards, claim UGP grant and ensure no notification badges shown on rewards icon.
  3. Link KYC'd bitFlyer account
  4. Close and "upgrade" to 1.46.x (rename profile to Beta).
  5. Ensure that brave://flags/#brave-rewards-webui-panel is enabled (currently this is done via griffin study).
  6. Verify that a notification badge is displayed on the Rewards icon.
  7. Open the Rewards panel.
  8. Verify that the only country available is Japan.
  9. Select Japan and click Continue.
  10. Confirm "Thank you" message is displayed.
  11. Close message and confirm panel information is shown.

image image image image image

Logs from step 9 
[22096:22096:1123/223320.037904:VERBOSE5:ledger_impl.cc(117)] 
[ REQUEST ]
> URL: https://grant.rewards.bravesoftware.com/v4/wallets/19396c0f-759d-47f2-980d-289b8d86fc49
> Method: PATCH
> Content: {"geoCountry":"JP"}
> Content Type: application/json; charset=utf-8
> Header digest: SHA-256=Me3rye9M1qvq7hjPKSFwYENAess0B71534D9pQlDJU4=
> Header signature: keyId="19396c0f-759d-47f2-980d-289b8d86fc49",algorithm="ed25519",headers="digest (request-target)",signature="8C96ZtY44K8x+e4/AAAWJYUMUxjAuqqS3UplzI2bO5cGpqlgO5ktS2cJm3NBQaL2MPBprPIQzoQuEX9TQME3Aw=="
> Header accept: application/json
[22096:22096:1123/223320.641008:VERBOSE6:logging_util.cc(134)] 
[ RESPONSE - OnResponse ]
> Url: https://grant.rewards.bravesoftware.com/v4/wallets/19396c0f-759d-47f2-980d-289b8d86fc49
> Result: Failure
> HTTP Code: 409
> Body: {"code":409,"message":"error updating rewards wallet: error geo country has already been set for rewards wallet"}
[22096:22096:1123/223320.667605:INFO:patch_wallets.cc(71)] geo_country already declared!
[22096:22096:1123/223320.677828:INFO:wallet_create.cc(105)] Failed to update Rewards wallet!
Linked Wallet Case: Gemini - PASSED
  1. Install 1.45.x (Release channel), relaunch to pull griffin seed.
  2. Enable Rewards, claim UGP grant and ensure no notification badges shown on rewards icon.
  3. Link KYC'd Gemini account
  4. Close and "upgrade" to 1.46.x (rename profile to Beta).
  5. Ensure that brave://flags/#brave-rewards-webui-panel is enabled (currently this is done via griffin study).
  6. Verify that a notification badge is displayed on the Rewards icon.
  7. Open the Rewards panel.
  8. Verify Japan is not available in the list.
  9. Select the country your account is KYC'd for and click Continue.
  10. Confirm "Thank you" message is displayed.
  11. Close message and confirm panel information is shown.

1.45.x image 1.46.x image image image image

Logs for step 9 
[ REQUEST ]
> URL: https://grant.rewards.bravesoftware.com/v4/wallets/efb5c7dd-d62c-4c46-a769-dcb5828d27a1
> Method: PATCH
> Content: {"geoCountry":"US"}
> Content Type: application/json; charset=utf-8
> Header digest: SHA-256=3qb2VxsOc3ttZ2t4p2mnCmhKFFOCcXpkoqc/iirXnIA=
> Header signature: keyId="efb5c7dd-d62c-4c46-a769-dcb5828d27a1",algorithm="ed25519",headers="digest (request-target)",signature="jbhCQlQvLeI9XejkX+DfyEl9rEXLf1QSxrqrntETAUSEjW49ZXupQG5JiHLCbBMUViaIn7xYiCYrn4sep0k8BA=="
> Header accept: application/json
[8509:8509:1128/161032.386309:VERBOSE6:logging_util.cc(134)] 
[ RESPONSE - OnResponse ]
> Url: https://grant.rewards.bravesoftware.com/v4/wallets/efb5c7dd-d62c-4c46-a769-dcb5828d27a1
> Result: Failure
> HTTP Code: 409
> Body: {"code":409,"message":"error updating rewards wallet: error geo country has already been set for rewards wallet"}

Note, in above logs the 409 response and UI shown is expected per doc linked in https://github.com/brave/internal/issues/894.

Linked Wallet Case: Uphold - PASSED
  1. Install 1.45.x (Release channel), relaunch to pull griffin seed.
  2. Enable Rewards, claim UGP grant and ensure no notification badges shown on rewards icon.
  3. Link KYC'd Uphold account
  4. Close and "upgrade" to 1.46.x (rename profile to Beta).
  5. Ensure that brave://flags/#brave-rewards-webui-panel is enabled (currently this is done via griffin study).
  6. Verify that a notification badge is displayed on the Rewards icon.
  7. Open the Rewards panel.
  8. Verify Japan is not available in the list.
  9. Select the country your account is KYC'd for and click Continue.
  10. Confirm "Thank you" message is displayed.
  11. Close message and confirm panel information is shown.

1.45.x image 1.46.x image image image image

Logs for step 9 

[10707:10707:1128/162415.212246:VERBOSE5:ledger_impl.cc(117)] 
[ REQUEST ]
> URL: https://grant.rewards.bravesoftware.com/v4/wallets/0b65956b-ba94-4ada-b5c9-a4c2df4b8ff4
> Method: PATCH
> Content: {"geoCountry":"US"}
> Content Type: application/json; charset=utf-8
> Header digest: SHA-256=3qb2VxsOc3ttZ2t4p2mnCmhKFFOCcXpkoqc/iirXnIA=
> Header signature: keyId="0b65956b-ba94-4ada-b5c9-a4c2df4b8ff4",algorithm="ed25519",headers="digest (request-target)",signature="mxvBf0+fJ3d8sacER594nb0LbWMbFc69q4V4xjTff+bIIcatgp+rnuOplJulw1ymtb32yZNySCuViaFusWlEAQ=="
> Header accept: application/json
[10707:10707:1128/162415.773971:VERBOSE6:logging_util.cc(134)] 
[ RESPONSE - OnResponse ]
> Url: https://grant.rewards.bravesoftware.com/v4/wallets/0b65956b-ba94-4ada-b5c9-a4c2df4b8ff4
> Result: Failure
> HTTP Code: 409
> Body: {"code":409,"message":"error updating rewards wallet: error geo country has already been set for rewards wallet"}
[10707:10707:1128/162415.781658:INFO:patch_wallets.cc(71)] geo_country already declared!
[10707:10707:1128/162415.783587:INFO:wallet_create.cc(105)] Failed to update Rewards wallet!

Note, in above logs the 409 response and UI shown is expected per doc linked in https://github.com/brave/internal/issues/894.

btlechowski avatar Nov 23 '22 22:11 btlechowski