brave-browser icon indicating copy to clipboard operation
brave-browser copied to clipboard

White space is not collapsed at the top of the page when nytimes.com site is loaded

Open MadhaviSeelam opened this issue 3 years ago • 1 comments

Description

Steps to Reproduce

  1. Install 1.42.85
  2. visit nytimes.com in NTP

Actual result:

White space is displayed at the top of the page in both default & aggressive shields settings

default aggressive
image image

Expected result:

White space should collapse

Reproduces how often:

Easily

Brave version (brave://version info)

Brave 1.42.85 Chromium: 104.0.5112.81 (Official Build) (64-bit)
Revision 5b7b76419d50f583022568b6764b630f6ddc9208-refs/branch-heads/5112@{#1309}
OS Windows 11 Version 21H2 (Build 22000.795)

Version/Channel Information:

  • Can you reproduce this issue with the current release? Yes
  • Can you reproduce this issue with the beta channel? Yes
  • Can you reproduce this issue with the nightly channel? No

Other Additional Information:

  • Does the issue resolve itself when disabling Brave Shields?
  • Does the issue resolve itself when disabling Brave Rewards?
  • Is the issue reproducible on the latest version of Chrome?

Miscellaneous Information:

cc: @rebron

MadhaviSeelam avatar Aug 02 '22 22:08 MadhaviSeelam

cc: @ryanbr @antonok-edm

rebron avatar Aug 09 '22 19:08 rebron

Lets see how this goes: https://github.com/easylist/easylist/commit/874f1fc2e69923e8f613fe9fb4cb9db2eff41027

Give it 24hrs and retest. If that fails, set sheilds = Aggressive @MadhaviSeelam

ryanbr avatar Aug 10 '22 23:08 ryanbr

@MadhaviSeelam how is it looking? Just tested, the top ad header briefly shows before collapsing from what I'm seeing

ryanbr avatar Aug 13 '22 06:08 ryanbr

@ryanbr White space collapsed with Aggressive shields setting. Didn't collapse in default setting.

MadhaviSeelam avatar Aug 15 '22 16:08 MadhaviSeelam

@MadhaviSeelam Should we close this one out as fixed or should we consider removing white space for the default setting?

rebron avatar Aug 30 '22 17:08 rebron

@ryanbr Any chance we can get hide as part of default shields setting?

rebron avatar Aug 31 '22 15:08 rebron

Looks okay currently @rebron . Is this working for you @MadhaviSeelam ?

nytimes-test

ryanbr avatar Sep 01 '22 09:09 ryanbr

Awesome & thanks @ryanbr. White space no longer displayed with default shields setting. Closing the issue.

image

MadhaviSeelam avatar Sep 07 '22 15:09 MadhaviSeelam