brave-browser icon indicating copy to clipboard operation
brave-browser copied to clipboard

Add option for `Prevent sites from fingerprinting me based on my language preferences`

Open srirambv opened this issue 3 years ago • 4 comments

Desktop has a setting Prevent sites from fingerprinting me based on my language preferences under shields which is missing on Android. Issue to track the implementation

cc: @ShivanKaul @pes10k @anthonypkeane @rebron @SergeyZhukovsky @Sam-Sibley

srirambv avatar Jul 07 '22 12:07 srirambv

It makes sense to put this setting underneath the "Block fingerprinting" option in settings -> Brave Shields & privacy. The desktop header text seems a too long for the Android menu:

Prevent sites from fingerprinting me based on my language preferences
Enabling this setting reduces how much web sites can learn about your language preferences.

Maybe we can shorten to:

Prevent fingerprinting via language preferences
Enabling this setting reduces how much web sites can learn about your language preferences.

@rmcfadden3 I will defer to you for the final copy.

cc @Sam-Sibley

timchilds avatar Jul 20 '22 19:07 timchilds

@timchilds — I like your version. Just a couple small tweaks, take em or leave em:

  • Header: Prevent fingerprinting via language settings
  • Body: Reduces how much websites can learn about you based on your browser's language settings.

rmcfadden3 avatar Jul 20 '22 21:07 rmcfadden3

@timchilds @anthonypkeane for this issue, we need to have brave-reduce-language flag enabled for android and it seems by default it's disabled. Should we enable it by default ? CC @srirambv @pes10k @pilgrim-brave

deeppandya avatar Aug 03 '22 06:08 deeppandya

Would be good to have the feature flag disabled by default in code, but enabled via griffin. Once its been rolled out and tested, we can enable the feature flag by default

pes10k avatar Aug 03 '22 21:08 pes10k

This issue is addressed by https://github.com/brave/brave-core/pull/14398

deeppandya avatar Aug 10 '22 15:08 deeppandya

Verification PASSED on Pixel 6 running Android 13 using the following build(s):

Brave | 1.44.97 Chromium: 106.0.5249.55 (Official Build) (64-bit)
--- | ---
Revision | 4d5f098fca6ab7f4b6b7c240be3d9593c2357709-refs/branch-heads/5249@{#531}
OS | Android 13; Build/T1B1.220819.006
  • ensured that the new setting string/text matches https://github.com/brave/brave-browser/issues/23919#issuecomment-1190783721
  • ensured that https://dev-pages.brave.software/fingerprinting/headers.html is working correctly when Prevent sites from fingerprinting me based on my language preferences is enabled & disabled

Prevent sites from fingerprinting me based on my language preferences enabled:

Setting Languages Default FP Aggressive FP Disabled FP
Screenshot_20220923-011037 Screenshot_20220923-011646 Screenshot_20220923-011657 Screenshot_20220923-011714 Screenshot_20220923-011728

Prevent sites from fingerprinting me based on my language preferences disabled:

Setting Languages Default FP Aggressive FP Disabled FP
Screenshot_20220923-013253 Screenshot_20220923-013313 Screenshot_20220923-013335 Screenshot_20220923-013352 Screenshot_20220923-013407

Verification PASSED on Samsung Tab S8 Ultra running Android 12 using the following build(s):

Brave | 1.44.97 Chromium: 106.0.5249.55 (Official Build) (32-bit)
--- | ---
Revision | 4d5f098fca6ab7f4b6b7c240be3d9593c2357709-refs/branch-heads/5249@{#531}
OS | Android 12; Build/SP2A.220305.013
  • ensured that the new setting string/text matches https://github.com/brave/brave-browser/issues/23919#issuecomment-1190783721
  • ensured that https://dev-pages.brave.software/fingerprinting/headers.html is working correctly when Prevent sites from fingerprinting me based on my language preferences is enabled & disabled

Prevent sites from fingerprinting me based on my language preferences enabled:

Setting Languages Default FP Aggressive FP Disabled FP
Screenshot_20220923_013851_Brave Screenshot_20220923_013922_Brave Screenshot_20220923_014020_Brave Screenshot_20220923_014041_Brave Screenshot_20220923_014052_Brave

Prevent sites from fingerprinting me based on my language preferences disabled:

Setting Languages Default FP Aggressive FP Disabled FP
Screenshot_20220923_014354_Brave Screenshot_20220923_014424_Brave Screenshot_20220923_014458_Brave Screenshot_20220923_014507_Brave Screenshot_20220923_014521_Brave

kjozwiak avatar Sep 23 '22 05:09 kjozwiak