brave-browser icon indicating copy to clipboard operation
brave-browser copied to clipboard

Allow for automatic revoking of Ethereum permissions

Open bbondy opened this issue 2 years ago • 2 comments

We currently don't revoke permissions, but we should figure out the best way to do that. See also: https://danajwright.medium.com/why-the-crypto-wallet-will-soon-be-a-thing-of-the-past-4c4167dc214a

bbondy avatar Mar 11 '22 22:03 bbondy

cc @iefremov @goodov for recommendations here

bbondy avatar Mar 11 '22 22:03 bbondy

PermissionLifetime should work for this.

Currently BraveEthereumPermissionContext with UI part is quite customized and doesn't set lifetime setting. It needs to call PermissionRequest::SetLifetime and PermissionLifetimeManager::PermissionDecided for PermissionLifetimeManager to properly track and reset a permission after some period.

goodov avatar Mar 14 '22 05:03 goodov