brave-browser
brave-browser copied to clipboard
`Brave.Rewards.WalletState` doesn't record values 3 & 4
Description
Found while testing #7634, Brave.Rewards.WalletState
doesn't record values 3 & 4
Steps to reproduce
- Clean install
- Switch to staging flag, do not claim grant
- Connect to Uphold account which has funds
- Wait for 10 sec, restart browser if required
- Brave.Rewards.WalletState stays at value 1
- Claim UGP grant
- Wait and check value still remains at 1
Actual result
Brave.Rewards.WalletState
doesn't record values 3 & 4
Expected result
Should update accordingly
Issue reproduces how often
Easy
Version/Channel Information:
- Can you reproduce this issue with the current Play Store version? NA
- Can you reproduce this issue with the current Play Store Beta version? Yes
- Can you reproduce this issue with the current Play Store Nightly version? Yes
Device details
- Install type (ARM, x86): ARM
- Device type (Phone, Tablet, Phablet): All
- Android version: All
Brave version
1.26.63
Website problems only
- Does the issue resolve itself when disabling Brave Shields? NA
- Does the issue resolve itself when disabling Brave Rewards? NA
- Is the issue reproducible on the latest version of Chrome? NA
Additional information
cc: @GeetaSarvadnya @emerick
Reproduced on Desktop also:
<!--StartFragment-->
Brave | 1.26.60 Chromium: 91.0.4472.101 (Official Build) beta (64-bit)
-- | --
Revision | af52a90bf87030dd1523486a1cd3ae25c5d76c9b-refs/branch-heads/4472@{#1462}
OS | Windows 10 OS Version 2004 (Build 19041.1052)
<!--EndFragment-->
Good find @srirambv !.
If we fund the wallet via restore wallet the P3A walletstate values are shown correctly. But when the wallet is funded via uphold the values are shown incorrectly. I am not sure how important this P3A value from a product point of view. Can we fix this issue as part of 1.26.x or defer to the next release?
cc: @bsclifton @emerick @rebron
@srirambv I think there's a misunderstanding here. In answer 4. Wallet created: no grants claimed; funds added
(which is what the browser reports as 3
) here, the "funds added" part refers to if the balance of the anonymous wallet is greater than 0. Linking your Rewards wallet to an Uphold account doesn't change your anonymous wallet balance, hence the browser keeps reporting 2. Wallet created; no grants claimed; no funds added
(as 1
). As to the browser not reporting 3. Wallet created; grant(s) claimed; no funds added
(as 2
) after claiming a grant, would you mind trying refreshing the brave://rewards
page after claiming the promotion? It should be reported on a successful balance fetch.
cc: @LaurenWags
Question has been removed, so no longer relevant.