adblock-rust
adblock-rust copied to clipboard
Review all potential panics in the entire codebase.
Review all potential panics. Rewrite the code to return errors wherever it makes sense. Comment on all cases where the panicking code is safe and explain why.
Cases:
expectorunwrapcalled in function returning aResult
I think this should follow the same rules as https://chromium.googlesource.com/chromium/src/+/HEAD/styleguide/c++/checks.md where panic would be equivalent to CHECK
we can also expose DumpWithoutCrashing to rust
Sounds like a good idea
can I try this as this is a good first issue?
/assign