adblock-rust icon indicating copy to clipboard operation
adblock-rust copied to clipboard

Review all potential panics in the entire codebase.

Open boocmp opened this issue 10 months ago • 4 comments

Review all potential panics. Rewrite the code to return errors wherever it makes sense. Comment on all cases where the panicking code is safe and explain why.

Cases:

  1. expect or unwrap called in function returning a Result

boocmp avatar Feb 12 '25 04:02 boocmp

I think this should follow the same rules as https://chromium.googlesource.com/chromium/src/+/HEAD/styleguide/c++/checks.md where panic would be equivalent to CHECK

we can also expose DumpWithoutCrashing to rust

bridiver avatar Feb 24 '25 16:02 bridiver

Sounds like a good idea

boocmp avatar Feb 25 '25 06:02 boocmp

can I try this as this is a good first issue?

vyalamar avatar Jun 07 '25 00:06 vyalamar

/assign

vyalamar avatar Jun 07 '25 00:06 vyalamar