adblock-rust-ffi icon indicating copy to clipboard operation
adblock-rust-ffi copied to clipboard

Backport from brave-core

Open bterrier opened this issue 2 years ago • 0 comments

The copy of adblock-rust-ffi living in brave-core has been updated. This commit backports all the valuable changes.

First, does it make sense to make pull request to this repo? It seems abandoned.

I did not backport changes that were made just for Brave like the change to the crate type or the #include of raw_ptr. I had to move from gnu++0x to c++17 to use std::optional instead of absl::optional, not sure if this is acceptable. I had to fix 2 tests because of the addition of try/catch blocks and "disable" 1 test because of an upstream breaking change in adblock-rust.

bterrier avatar Jul 25 '22 15:07 bterrier